<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2836/">https://reviewboard.asterisk.org/r/2836/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/2836/diff/1/?file=45707#file45707line4" style="color: black; font-weight: bold; text-decoration: underline;">./tests/channels/pjsip/message/message_basic/test-config.yaml</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">4</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="no">'Send Asterisk a MESSAGE and wait for Asterisk to send it back.'</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This description is misleading. It sounds like there is one party that sends a MESSAGE to Asterisk, and then Asterisk echoes the MESSAGE back to the party that sent it.
Other tests have similar language in them, so I won't bother putting similar comments on them.</pre>
</div>
<br />
<p>- Mark</p>
<br />
<p>On September 9th, 2013, 2:58 p.m. UTC, Kevin Harwell wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Kevin Harwell.</div>
<p style="color: grey;"><i>Updated Sept. 9, 2013, 2:58 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
testsuite
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Testsuite tests for pjsip messaging. Some have been ported from the old sip messaging tests (chan_sip) and have been updated to work with the new sip channel driver. Tests include messages with custom headers, messages from various identifiers, in dialog messaging, and messages via ami.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ran test against 12 to make sure they completed successfully.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>./tests/channels/pjsip/message/message_basic/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>./tests/channels/pjsip/message/message_basic/configs/ast1/pjsip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>./tests/channels/pjsip/message/message_basic/sipp/message.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>./tests/channels/pjsip/message/message_basic/sipp/message_recv.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>./tests/channels/pjsip/message/message_basic/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>./tests/channels/pjsip/message/message_cust_hdr/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>./tests/channels/pjsip/message/message_cust_hdr/configs/ast1/pjsip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>./tests/channels/pjsip/message/message_cust_hdr/sipp/message.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>./tests/channels/pjsip/message/message_cust_hdr/sipp/message_recv.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>./tests/channels/pjsip/message/message_cust_hdr/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>./tests/channels/pjsip/message/message_from/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>./tests/channels/pjsip/message/message_from/configs/ast1/pjsip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>./tests/channels/pjsip/message/message_from/sipp/message.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>./tests/channels/pjsip/message/message_from/sipp/message_recv.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>./tests/channels/pjsip/message/message_from/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>./tests/channels/pjsip/message/message_in_dialog/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>./tests/channels/pjsip/message/message_in_dialog/configs/ast1/pjsip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>./tests/channels/pjsip/message/message_in_dialog/sipp/message.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>./tests/channels/pjsip/message/message_in_dialog/sipp/message.xml.old <span style="color: grey">(PRE-CREATION)</span></li>
<li>./tests/channels/pjsip/message/message_in_dialog/sipp/message_recv.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>./tests/channels/pjsip/message/message_in_dialog/sipp/message_recv.xml.old <span style="color: grey">(PRE-CREATION)</span></li>
<li>./tests/channels/pjsip/message/message_in_dialog/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>./tests/channels/pjsip/message/message_send_ami/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>./tests/channels/pjsip/message/message_send_ami/configs/ast1/manager.users.conf.inc <span style="color: grey">(PRE-CREATION)</span></li>
<li>./tests/channels/pjsip/message/message_send_ami/configs/ast1/pjsip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>./tests/channels/pjsip/message/message_send_ami/run-test <span style="color: grey">(PRE-CREATION)</span></li>
<li>./tests/channels/pjsip/message/message_send_ami/sipp/message_recv.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>./tests/channels/pjsip/message/message_send_ami/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>./tests/channels/pjsip/message/tests.yaml <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2836/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>