<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2767/">https://reviewboard.asterisk.org/r/2767/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers and Mark Michelson.</div>
<div>By jbigelow.</div>
<p style="color: grey;"><i>Updated Sept. 9, 2013, 4:24 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Committed in revision 4136</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
testsuite
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The pjsip tests that identify by host are actually being identified by user. This patch allows the inbound calls to be identified by host/IP as they once were but in a different way.
It appears this was caused by revision 3967 when the modules.conf files were removed from the tests which loaded just one of the identifier modules being res_pjsip_endpoint_identifier_ip.so. Now without the modules.conf files, Asterisk loads the res_pjsip_endpoint_identifier_user.so module first before the other identifier modules thus identifying by user first.
By changing the From header in the scenarios, a user/endpoint won't be matched allowing them to be identified by host/IP as intended. I figured this was a better solution rather than adding a modules.conf to the tests containing a noload for res_pjsip_endpoint_identifier_user.so</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">* Verified that the logs do not contain the Asterisk debug message "Retrieved endpoint %s" since the calls are being identified by host/IP instead.
* Ensured the tests pass</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/incoming/nominal/authed/md5/ident_by_host/configs/ast1/pjsip.conf <span style="color: grey">(4025)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/incoming/nominal/authed/md5/ident_by_host/sipp/echo_with_deferred_sdp.xml <span style="color: grey">(4025)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/incoming/nominal/authed/md5/ident_by_host/sipp/echo_with_initial_sdp.xml <span style="color: grey">(4025)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/incoming/nominal/authed/md5/ident_by_host/sipp/playback_with_deferred_sdp.xml <span style="color: grey">(4025)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/incoming/nominal/authed/md5/ident_by_host/sipp/playback_with_initial_sdp.xml <span style="color: grey">(4025)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/incoming/nominal/authed/userpass/ident_by_host/configs/ast1/pjsip.conf <span style="color: grey">(4025)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/incoming/nominal/authed/userpass/ident_by_host/sipp/echo_with_deferred_sdp.xml <span style="color: grey">(4025)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/incoming/nominal/authed/userpass/ident_by_host/sipp/echo_with_initial_sdp.xml <span style="color: grey">(4025)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/incoming/nominal/authed/userpass/ident_by_host/sipp/playback_with_deferred_sdp.xml <span style="color: grey">(4025)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/incoming/nominal/authed/userpass/ident_by_host/sipp/playback_with_initial_sdp.xml <span style="color: grey">(4025)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_host/configs/ast1/pjsip.conf <span style="color: grey">(4025)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_host/sipp/echo_with_deferred_sdp.xml <span style="color: grey">(4025)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_host/sipp/echo_with_initial_sdp.xml <span style="color: grey">(4025)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_host/sipp/playback_with_deferred_sdp.xml <span style="color: grey">(4025)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_host/sipp/playback_with_initial_sdp.xml <span style="color: grey">(4025)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2767/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>