<div dir="ltr">Can I suggest 1 more test? Since I had to change where the default of "asterisk" is set for outbound 401/407 challenges, a test to make sure the default is still set correctly would probably be good. I'll sleep better. :)</div>
<div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Sep 6, 2013 at 12:42 PM, Mark Michelson <span dir="ltr"><<a href="mailto:reviewboard@asterisk.org" target="_blank">reviewboard@asterisk.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>
<div style="font-family:Verdana,Arial,Helvetica,Sans-Serif">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border:1px #c9c399 solid">
<tbody><tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2829/" target="_blank">https://reviewboard.asterisk.org/r/2829/</a>
</td>
</tr>
</tbody></table>
<br>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image:url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png');background-repeat:repeat-x;border:1px black solid">
<tbody><tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Mark Michelson.</div>
<p style="color:grey"><i>Updated Sept. 6, 2013, 6:42 p.m.</i></p>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border:1px solid #b8b5a0">
<tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">Updated description in test-config.yaml to be more accurate.</pre>
</td>
</tr>
</tbody></table>
<div style="margin-top:1.5em">
<b style="color:#575012;font-size:10pt;margin-top:1.5em">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-22386" target="_blank">ASTERISK-22386</a>,
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-22471" target="_blank">ASTERISK-22471</a>
</div>
<div style="margin-top:1.5em">
<b style="color:#575012;font-size:10pt">Repository: </b>
testsuite
</div>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border:1px solid #b8b5a0">
<tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">On ASTERISK-22471, George Joseph created a patch that eases the burden of outbound authentication. If no realm is specified in an auth section, then we will simply mirror the realm presented in the 401/407 response that we receive.
Since this patch is a candidate for Asterisk 12, it is required to have test coverage. This set of tests exercises outbound authentication. The test starts up two Asterisk instances, uut and bob. uut places four outbound calls to bob. Bob challenges each of the four calls the exact same way; however, the authentication is configured four different ways on uut. uut is expected to be able to respond to each of the four challenges correctly.
The four methods of authentication configuration are:
1. Userpass authentication, explicit realm present.
2. Userpass authentication, no realm specified.
3. MD5 authentication, explicit realm present.
4. MD5 authentictaion, no realm specified.</pre>
</td>
</tr>
</tbody></table>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border:1px solid #b8b5a0">
<tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">The tests pass with the patch from ASTERISK-22471 applied. Without the patch, cases 2 and 4 are unable to authenticate properly.</pre>
</td>
</tr>
</tbody></table>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Diffs (updated)</h1>
<ul style="margin-left:3em;padding-left:0">
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/outgoing/nominal/auth/configs/ast1/extensions.conf <span style="color:grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/outgoing/nominal/auth/configs/ast1/pjsip.conf <span style="color:grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/outgoing/nominal/auth/configs/ast2/extensions.conf <span style="color:grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/outgoing/nominal/auth/configs/ast2/pjsip.conf <span style="color:grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/outgoing/nominal/auth/test-config.yaml <span style="color:grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/outgoing/nominal/tests.yaml <span style="color:grey">(4126)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2829/diff/" style="margin-left:3em" target="_blank">View Diff</a></p>
</td>
</tr>
</tbody></table>
</div>
</div>
<br>--<br>
_____________________________________________________________________<br>
-- Bandwidth and Colocation Provided by <a href="http://www.api-digital.com" target="_blank">http://www.api-digital.com</a> --<br>
<br>
asterisk-dev mailing list<br>
To UNSUBSCRIBE or update options visit:<br>
<a href="http://lists.digium.com/mailman/listinfo/asterisk-dev" target="_blank">http://lists.digium.com/mailman/listinfo/asterisk-dev</a><br></blockquote></div><br></div>