<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Sep 4, 2013 at 3:41 PM, Joshua Colp <span dir="ltr"><<a href="mailto:jcolp@digium.com" target="_blank">jcolp@digium.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div class="im">George Joseph wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>
Gotcha. If you give me some naming convention guidance, I can work on<br>
both the SIP equivalents and config stuff (which would be needed to<br>
duplicate SIPPEER anyway) using PJSIP_DIAL_CONTACTS and<br>
PJSIP_MEDIA_OFFER as templates.<br>
</blockquote>
<br></div>
Changing the names is a minor thing, so just go with what feels right. Note: We have no peers though.<div class="im"><br></div></blockquote><div><br></div><div style>My personal preference (although I'm certainly open to any alternatives):</div>
<div style><br></div><div style>SIPPEER -> PJSIP_ENDPOINT</div><div style>SIP_HEADER -> PJSIP_HEADER (thoughts below on this)</div><div style>SIPCHANINFO -> PJSIP_CHAN_INFO</div><div style><br></div><div style>As far as SipAddHeader/SipRemoveHeader go - it always felt a little wonky that these were dialplan applications, particularly when we have SIP_HEADER as a function. It feels like this could be easily:</div>
<div style><br></div><div style>${PJSIP_HEADER(X-foo)} - equivalent to SIP_HEADER</div><div style>Set(PJSIP_HEADER(X-foo)=bar) - equivalent to SipAddHeader</div><div style>Set(PJSIP_HEADER(X-foo)=) - equivalent to SipRemoveHeader</div>
<div style><br></div><div style>The last one is the most tricky, as it is debatable whether or not certain headers (such as Allow) can be empty. If we need to allow empty headers, another option would be to explicitly specify 'remove' as the second parameter to the function:</div>
<div style><br></div><div style>Set(PJSIP_HEADER(X-foo,remove)=)</div><div style><br></div><div style>Just some thoughts.</div><div style><br></div><div style>It'd be fantastic for someone to contribute those patches - let us know if you need any help/pointers!</div>
<div><br></div></div>-- <br><div dir="ltr"><div>Matthew Jordan<br></div><div>Digium, Inc. | Engineering Manager</div><div>445 Jan Davis Drive NW - Huntsville, AL 35806 - USA</div><div>Check us out at: <a href="http://digium.com" target="_blank">http://digium.com</a> & <a href="http://asterisk.org" target="_blank">http://asterisk.org</a></div>
</div>
</div></div>