<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2823/">https://reviewboard.asterisk.org/r/2823/</a>
</td>
</tr>
</table>
<br />
<p>On September 4th, 2013, 9:07 p.m. UTC, <b>Mark Michelson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hmm, I left some general feedback in my review that seems to have been swallowed by Internet goblins. Here's what should have been present.
* Capitalization is a bit off in certain cases. It's customary when describing SIP headers to capitalize the name of the header (e.g. "Contact") but not the word "header". In addition, there are some parts that you did not change where the words "permit" and "deny" are capitalized despite not being the first word in the sentence.
* It's a bit wordy to mention that an option may be either an individual item or a comma-delimited list of items. If you just mention that it's a comma-delimited list of items, that implies the case where a list of only one item is present.</pre>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks. I agree with all of what you said here. "Contact Header" was in the original text, and I wasn't sure why so I left it that way. That did seem weird.
</pre>
<br />
<p>- rnewton</p>
<br />
<p>On September 4th, 2013, 7:59 p.m. UTC, rnewton wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By rnewton.</div>
<p style="color: grey;"><i>Updated Sept. 4, 2013, 7:59 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-22458">ASTERISK-22458</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">One bug fix. The synopsis for "type" was wrong.
When Mark and I were looking at some ACL issue we noted that there should be some improvements to the documentation.
Notably:
* changing the usage of "IP-domains" to "IP addresses"
* clarifying the usage for the options, by adding a relevant description for each
* modified other areas of the XML help for clarity, such as the module description and a few synopsis changes here and there. See the patch.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/12/res/res_pjsip_acl.c <span style="color: grey">(398277)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2823/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>