<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2808/">https://reviewboard.asterisk.org/r/2808/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers and Mark Michelson.</div>
<div>By jbigelow.</div>
<p style="color: grey;"><i>Updated Sept. 2, 2013, 9:10 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Committed in revision 4099</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-22283">ASTERISK-22283</a>,
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-22285">ASTERISK-22285</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
testsuite
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">These tests cover nominal outgoing and two-party PJSIP tests. Each test has iterations for IPv4/IPv6 and UDP/TCP. These cover tests 1 and 2 of the nominal outgoing tests and tests 1 and 2 of the nominal two-party call tests initiated by Alice as listed on the test plan page of the wiki.
*NOTE:* Many of these tests currently fail due to multiple bugs in Asterisk which and have been reported. Changes may be required to the tests once the Asterisk bugs are resolved.
Nominal outgoing tests:
* playback - Originate a call from the uut to bob with directing the answered call to the Playback() application. Bob answers and listens for audio received from the uut. The uut then hangs up. This ensures that bob receives the audio from the uut.
* echo - Originate a call from the uut to bob with directing the answered call to the Echo() application. Bob answers and sends audio while listening for audio received from the uut. Bob then hangs up. This ensures that bob receives the echoed audio from the uut.
Nominal alice initiated two-party tests:
* alice_hangs_up - Using three instances of Asterisk, Both alice and bob send audio to each other while both also listen for audio. Alice then initiates the hang. This ensures that both alice and bob receive audio.
* bob_hangs_up - Using three instances of Asterisk, Both alice and bob send audio to each other while both also listen for audio. Bob then initiates the hang. This ensures that both alice and bob receive audio.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Since many of these fail due to multiple bugs in Asterisk (see note above) I could only verify the tests based on limited successful behavior.
* Verified that audio is received as specified for each test when calls actually go through
* Verified failures are due to bugs found in Asterisk.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/two_parties/tests.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/two_parties/nominal/tests.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/two_parties/nominal/alice_initiated/tests.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/two_parties/nominal/alice_initiated/bob_hangs_up/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/two_parties/nominal/alice_initiated/bob_hangs_up/configs/ast3/pjsip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/two_parties/nominal/alice_initiated/bob_hangs_up/configs/ast3/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/two_parties/nominal/alice_initiated/bob_hangs_up/configs/ast2/pjsip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/two_parties/nominal/alice_initiated/bob_hangs_up/configs/ast2/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/two_parties/nominal/alice_initiated/bob_hangs_up/configs/ast1/pjsip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/two_parties/nominal/alice_initiated/bob_hangs_up/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/two_parties/nominal/alice_initiated/alice_hangs_up/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/two_parties/nominal/alice_initiated/alice_hangs_up/configs/ast3/pjsip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/two_parties/nominal/alice_initiated/alice_hangs_up/configs/ast3/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/two_parties/nominal/alice_initiated/alice_hangs_up/configs/ast2/pjsip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/two_parties/nominal/alice_initiated/alice_hangs_up/configs/ast2/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/two_parties/nominal/alice_initiated/alice_hangs_up/configs/ast1/pjsip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/two_parties/nominal/alice_initiated/alice_hangs_up/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/tests.yaml <span style="color: grey">(4098)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/outgoing/tests.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/outgoing/nominal/tests.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/outgoing/nominal/playback/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/outgoing/nominal/playback/configs/ast2/pjsip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/outgoing/nominal/playback/configs/ast2/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/outgoing/nominal/playback/configs/ast1/pjsip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/outgoing/nominal/playback/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/outgoing/nominal/echo/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/outgoing/nominal/echo/configs/ast1/pjsip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/outgoing/nominal/echo/configs/ast2/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/outgoing/nominal/echo/configs/ast2/pjsip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/basic_calls/outgoing/nominal/echo/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2808/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>