<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2816/">https://reviewboard.asterisk.org/r/2816/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers, kmoore and Matt Jordan.</div>
<div>By jrose.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-22328">ASTERISK-22328</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
testsuite
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Update the parkcall_timeout tests (comebacktoorigin_yes and comebacktoorigin_no) to address differences in how things work between 12 and previous version. Again, events and CDR expectations mostly, but it turned out Asterisk 11 was really failing the parkcall_timeout/comebacktoorigin_yes test and wasn't being reported as such. 11 doesn't set certain channel variables (PARKINGLOT and PARKINGSLOT/PARKINGSPACE) when comebacktoorigin = yes which are set when it is set to no. Asterisk 12 applies these channel variables regardless of that condition (this is a change that was discussed and we decided it was a positive and unobtrusive one).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested both tests for Asterisk 11 and 12 to make sure they pass.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/asterisk/trunk/tests/bridge/parkcall_timeout/comebacktoorigin_no/test-config.yaml <span style="color: grey">(4081)</span></li>
<li>/asterisk/trunk/tests/bridge/parkcall_timeout/comebacktoorigin_yes/Executioner.py <span style="color: grey">(4081)</span></li>
<li>/asterisk/trunk/tests/bridge/parkcall_timeout/comebacktoorigin_yes/configs/ast1/res_parking.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/bridge/parkcall_timeout/comebacktoorigin_yes/test-config.yaml <span style="color: grey">(4081)</span></li>
<li>/asterisk/trunk/tests/bridge/tests.yaml <span style="color: grey">(4081)</span></li>
<li>/asterisk/trunk/tests/bridge/parkcall_timeout/comebacktoorigin_no/Executioner.py <span style="color: grey">(4081)</span></li>
<li>/asterisk/trunk/tests/bridge/parkcall_timeout/comebacktoorigin_no/configs/ast1/res_parking.conf <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2816/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>