<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2703/">https://reviewboard.asterisk.org/r/2703/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I can verify that it compiles and runs for me. Beyond that, no objections.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/2703/diff/1/?file=42575#file42575line28" style="color: black; font-weight: bold; text-decoration: underline;">trunk/include/asterisk/event_defs.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">28</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cm">/*! \brief Event types</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">28</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cm">/*! \brief Event types</span></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">29</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cm"> * \note These values can *never* change. */</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">29</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cm"> * \note These values no longer go over the wire and can change when items are removed. */</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Unless there's a real reason to change the enum values, I wonder if it would be less trouble long term to just leave them at their current values.
I can't think of any reason why changing them would be a problem. It's the things I can't think of that worry me.</pre>
</div>
<br />
<p>- David</p>
<br />
<p>On July 26th, 2013, 9:48 a.m. CDT, opticron wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By opticron.</div>
<p style="color: grey;"><i>Updated July 26, 2013, 9:48 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-22139">ASTERISK-22139</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This removes unused code, event types, IE pltypes, and event IE types where possible and makes several functions private that were once public. This includes a renumbering of the remaining event and IE types which breaks binary compatibility with previous versions. The last remaining consumers of the old event system (or parts thereof) are main/security_events.c, res/res_security_log.c, tests/test_cel.c, tests/test_event.c, main/cel.c, and the CEL backends.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Made sure that CEL and event system unit tests still pass.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/apps/app_queue.c <span style="color: grey">(395498)</span></li>
<li>trunk/apps/app_voicemail.c <span style="color: grey">(395498)</span></li>
<li>trunk/channels/chan_dahdi.c <span style="color: grey">(395498)</span></li>
<li>trunk/channels/chan_iax2.c <span style="color: grey">(395498)</span></li>
<li>trunk/channels/chan_mgcp.c <span style="color: grey">(395498)</span></li>
<li>trunk/channels/chan_sip.c <span style="color: grey">(395498)</span></li>
<li>trunk/channels/chan_skinny.c <span style="color: grey">(395498)</span></li>
<li>trunk/channels/chan_unistim.c <span style="color: grey">(395498)</span></li>
<li>trunk/channels/sig_pri.h <span style="color: grey">(395498)</span></li>
<li>trunk/channels/sig_pri.c <span style="color: grey">(395498)</span></li>
<li>trunk/funcs/func_presencestate.c <span style="color: grey">(395498)</span></li>
<li>trunk/include/asterisk/devicestate.h <span style="color: grey">(395498)</span></li>
<li>trunk/include/asterisk/event.h <span style="color: grey">(395498)</span></li>
<li>trunk/include/asterisk/event_defs.h <span style="color: grey">(395498)</span></li>
<li>trunk/include/asterisk/security_events_defs.h <span style="color: grey">(395498)</span></li>
<li>trunk/main/ccss.c <span style="color: grey">(395498)</span></li>
<li>trunk/main/devicestate.c <span style="color: grey">(395498)</span></li>
<li>trunk/main/event.c <span style="color: grey">(395498)</span></li>
<li>trunk/main/manager.c <span style="color: grey">(395498)</span></li>
<li>trunk/main/pbx.c <span style="color: grey">(395498)</span></li>
<li>trunk/main/presencestate.c <span style="color: grey">(395498)</span></li>
<li>trunk/main/security_events.c <span style="color: grey">(395498)</span></li>
<li>trunk/res/parking/parking_applications.c <span style="color: grey">(395498)</span></li>
<li>trunk/res/parking/parking_manager.c <span style="color: grey">(395498)</span></li>
<li>trunk/res/parking/parking_ui.c <span style="color: grey">(395498)</span></li>
<li>trunk/res/res_jabber.c <span style="color: grey">(395498)</span></li>
<li>trunk/res/res_parking.c <span style="color: grey">(395498)</span></li>
<li>trunk/res/res_security_log.c <span style="color: grey">(395498)</span></li>
<li>trunk/res/res_xmpp.c <span style="color: grey">(395498)</span></li>
<li>trunk/tests/test_cel.c <span style="color: grey">(395498)</span></li>
<li>trunk/tests/test_event.c <span style="color: grey">(395498)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2703/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>