<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2736/">https://reviewboard.asterisk.org/r/2736/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/2736/diff/1/?file=43667#file43667line3" style="color: black; font-weight: bold; text-decoration: underline;">/asterisk/trunk/tests/channels/pjsip/registration/inbound/off-nominal/unregister/tests.yaml</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">3</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="p-Indicator">-</span> <span class="l-Scalar-Plain">test</span><span class="p-Indicator">:</span> <span class="s">'single_contact'</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'd rename this one from single_contact to something else. The test isn't checking unregistration of a single contact, it's checking that if we don't provide an Expires header we reject the request.
How about 'no_expire'?</pre>
</div>
<br />
<p>- Matt</p>
<br />
<p>On August 2nd, 2013, 10:25 p.m. UTC, jbigelow wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By jbigelow.</div>
<p style="color: grey;"><i>Updated Aug. 2, 2013, 10:25 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
testsuite
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This test sends registrations over IPv4/IPv6 and UDP/TCP to test nominal and off-nominal inbound unregistrations. This covers tests 1, 2, and 3 of the nominal tests and test 1 of the off-nominal tests listed on the test plan page of the wiki.
A single ast_test_suite_event_notify was added to res_pjsip_registrar.c to make the 'all_contacts' test possible. An ast_verb was also added to be consistent but none of these tests depend on it. See review 2739 (https://reviewboard.asterisk.org/r/2739/)
Nominal unregister tests:
* single_contact - first register a contact and then immediately unregister the contact. This ensures that by setting a value of 0 in the Expires header, the contact is unregistered from Asterisk.
* multiple_contacts - first register contacts and then immediately unregister the contacts using an Expires header of 0. This is repeated again except for unregistration the Expires header is set to none 0 and the expires parameter is set to 0 for the contacts. This ensures that both methods cause the contacts to be unregistered from Asterisk.
* all_contacts - first register contacts and then immediately unregister all contacts specifing a Contact header of "*" and an Expires header of 0. This ensures that using a "*" for the Contact header causes Asterisk to unregister all contacts for each AOR.
Off-nominal unregister tests:
* single_contact - first register a contact and then immediately attempt to unregister the contact by using "*" for the Contact header and without an Expires header present. This ensures that Asterisk rejects the unregistration attempt since it is invalid.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">* Ensured the tests fail if:
- the Test Events aren't received or do not match. (all tests)
- the contact header(s) exists when it shouldn't. (nominal tests 1, 2, and 3)
- contacts are not unregistered. (nominal tests 1, 2, and 3)
- a 400 Bad Request isn't received from Asterisk. (off-nominal test 1)
* Review logs to ensure that the registrations were using all the combinations of IPv4/IPv6 and UDP/TCP.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/tests.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/unregister/all_contacts/configs/ast1/pjsip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/unregister/all_contacts/sipp/register-noauth-ipv4.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/unregister/all_contacts/sipp/register-noauth-ipv6.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/unregister/all_contacts/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/unregister/multiple_contacts/configs/ast1/pjsip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/unregister/multiple_contacts/sipp/register-noauth-ipv4.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/unregister/multiple_contacts/sipp/register-noauth-ipv6.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/unregister/multiple_contacts/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/unregister/single_contact/configs/ast1/pjsip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/unregister/single_contact/sipp/register-noauth.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/unregister/single_contact/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/unregister/tests.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/registration/inbound/off-nominal/tests.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/registration/inbound/off-nominal/unregister/single_contact/configs/ast1/pjsip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/registration/inbound/off-nominal/unregister/single_contact/sipp/register-noauth.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/registration/inbound/off-nominal/unregister/single_contact/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/registration/inbound/off-nominal/unregister/tests.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/registration/inbound/tests.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/registration/tests.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/tests.yaml <span style="color: grey">(3972)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2736/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>