<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/2722/">https://reviewboard.asterisk.org/r/2722/</a>
     </td>
    </tr>
   </table>
   <br />



 <p>Ship it!</p>



 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
 <br />









<p>- Matt</p>


<br />
<p>On July 31st, 2013, 7:12 p.m. UTC, jbigelow wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Asterisk Developers.</div>
<div>By jbigelow.</div>


<p style="color: grey;"><i>Updated July 31, 2013, 7:12 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
testsuite
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This includes 3 off-nominal registration tests for pjsip. Each test is performed using IPv4/IPv6 and UDP/TCP. These cover tests 2, 3, and 4 of the off-nominal inbound registrations listed on the test plan page of the wiki.

* Test no_contact_header - sends a REGISTER to Asterisk which does not contain a Contact header. Ensures that the 200 OK received from Asterisk does not contain a Contact header either.

* Test max_contacts - sends a REGISTER to Asterisk with two contacts. This ensures that Asterisk responds with a 403 Forbidden since the pjsip configuration option &#39;max_contacts&#39; is set to 1.

* Test wrong_password - attempt to register to Asterisk using a password that does not match the pjsip configuration. This ensures that Asterisk rejects the registration attempt with a 401 Unauthorized message.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">* Ensured the tests fail if:
- the 200 OK does contain a Contact header
- a 403 Forbidden is not received
- a 401 Unauthorized is not received
* Review logs to ensure that the registrations were using all the combinations of IPv4/IPv6 and UDP/TCP.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/asterisk/trunk/tests/channels/pjsip/registration/inbound/off-nominal/wrong_password/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/trunk/tests/channels/pjsip/registration/inbound/off-nominal/wrong_password/sipp/register-wrong-password.xml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/trunk/tests/channels/pjsip/registration/inbound/off-nominal/wrong_password/configs/ast1/pjsip.conf <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/trunk/tests/channels/pjsip/registration/inbound/off-nominal/tests.yaml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/trunk/tests/channels/pjsip/registration/inbound/off-nominal/no_contact_header/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/trunk/tests/channels/pjsip/registration/inbound/off-nominal/no_contact_header/sipp/register-noauth-no-contact-header.xml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/trunk/tests/channels/pjsip/registration/inbound/off-nominal/no_contact_header/configs/ast1/pjsip.conf <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/trunk/tests/channels/pjsip/registration/inbound/off-nominal/max_contacts/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/trunk/tests/channels/pjsip/registration/inbound/off-nominal/max_contacts/sipp/register-too-many-contacts.xml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/trunk/tests/channels/pjsip/registration/inbound/off-nominal/max_contacts/configs/ast1/pjsip.conf <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/trunk/tests/channels/pjsip/registration/inbound/tests.yaml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/trunk/tests/channels/pjsip/registration/tests.yaml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/trunk/tests/channels/pjsip/tests.yaml <span style="color: grey">(3972)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/2722/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>








  </div>
 </body>
</html>