<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2712/">https://reviewboard.asterisk.org/r/2712/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Mark Michelson.</div>
<p style="color: grey;"><i>Updated Aug. 2, 2013, 9:13 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Committed in revision 396107</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-22193">ASTERISK-22193</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This does two things:
1) The stasis event for channels entering bridges now also includes the unique ID of a channel being swapped out of the bridge if relevant.
2) The stasis event for parking a call now has another event type for swapping out the parked channel.
Both of these are intended for clarity when reading the AMI event stream. The idea is that it becomes more clear that a channel entering a bridge or parking lot is doing so to take the place of a channel already there.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Performed a call where I did an attended transfer of a party to a parking lot. The BridgeEnter event when the transferee entered the parking lot indicated the unique ID of the transferer channel that initially was in the parking bridge. Then a ParkedCallSwap event occurred to show that the channel in the parking lot was replaced with a new channel.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/main/cel.c <span style="color: grey">(395704)</span></li>
<li>/trunk/main/bridge_channel.c <span style="color: grey">(395704)</span></li>
<li>/trunk/include/asterisk/stasis_bridges.h <span style="color: grey">(395704)</span></li>
<li>/trunk/include/asterisk/parking.h <span style="color: grey">(395704)</span></li>
<li>/trunk/main/stasis_bridges.c <span style="color: grey">(395704)</span></li>
<li>/trunk/res/parking/parking_bridge.c <span style="color: grey">(395704)</span></li>
<li>/trunk/res/parking/parking_manager.c <span style="color: grey">(395704)</span></li>
<li>/trunk/main/manager_bridges.c <span style="color: grey">(395704)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2712/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>