<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2731/">https://reviewboard.asterisk.org/r/2731/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/2731/diff/1/?file=43460#file43460line38" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/contrib/ast-db-manage/config/versions/4da0c5f79a9c_create_tables.py</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">38</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="n">SIP_TRANSPORT_VALUES</span> <span class="o">=</span> <span class="p">[</span><span class="s">'udp'</span><span class="p">,</span> <span class="s">'tcp'</span><span class="p">,</span> <span class="s">'udp,tcp'</span><span class="p">,</span> <span class="s">'tcp,udp'</span><span class="p">]</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What about 'tls' ?</pre>
</div>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">But I too favor the old SQL files over an extra Alembic dependency and less readable files.
If however using Alembic makes it easier to update the in-tree SQL files, I could see some use for it there.</pre>
<p>- wdoekes</p>
<br />
<p>On August 1st, 2013, 4:12 a.m. UTC, Russell Bryant wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Russell Bryant.</div>
<p style="color: grey;"><i>Updated Aug. 1, 2013, 4:12 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch replaces contrib/realtime/ with a new setup for managing the database schema required for database integration with Asterisk. In addition to initializing a database with the proper schema, alembic can do a database migration to assist with upgrading Asterisk in the future. Hopefully this helps make setting up and operating Asterisk with a database easier.
With this the schema only needs to be maintained in one place instead of once per database. The schemas I have added here have a bit of improvement over the examples that were there before (some added consistency and added some missing indexes). Managing the schema in one place here also applies to all databases supported by SQLAlchemy.
See contrib/ast-db-manage/README.md for more details.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I ran schema upgrade/downgrade against MariaDB (MySQL compatible). The schema came out as expected. I haven't hooked it up to Asterisk, though...</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/CHANGES <span style="color: grey">(395934)</span></li>
<li>/trunk/contrib/ast-db-manage/README.md <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/contrib/ast-db-manage/config.ini.sample <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/contrib/ast-db-manage/config/env.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/contrib/ast-db-manage/config/script.py.mako <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/contrib/ast-db-manage/config/versions/4da0c5f79a9c_create_tables.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/contrib/ast-db-manage/voicemail.ini.sample <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/contrib/ast-db-manage/voicemail/env.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/contrib/ast-db-manage/voicemail/script.py.mako <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/contrib/ast-db-manage/voicemail/versions/a2e9769475e_create_tables.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/contrib/realtime/mysql/iaxfriends.sql <span style="color: grey">(395934)</span></li>
<li>/trunk/contrib/realtime/mysql/meetme.sql <span style="color: grey">(395934)</span></li>
<li>/trunk/contrib/realtime/mysql/musiconhold.sql <span style="color: grey">(395934)</span></li>
<li>/trunk/contrib/realtime/mysql/queue_log.sql <span style="color: grey">(395934)</span></li>
<li>/trunk/contrib/realtime/mysql/sippeers.sql <span style="color: grey">(395934)</span></li>
<li>/trunk/contrib/realtime/mysql/voicemail.sql <span style="color: grey">(395934)</span></li>
<li>/trunk/contrib/realtime/mysql/voicemail_data.sql <span style="color: grey">(395934)</span></li>
<li>/trunk/contrib/realtime/mysql/voicemail_messages.sql <span style="color: grey">(395934)</span></li>
<li>/trunk/contrib/realtime/postgresql/realtime.sql <span style="color: grey">(395934)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2731/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>