<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2726/">https://reviewboard.asterisk.org/r/2726/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers, Matt Jordan, opticron, and rmudgett.</div>
<div>By David Lee.</div>
<p style="color: grey;"><i>Updated July 31, 2013, 8:17 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Didn't mean to include that features_config change.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-22084">ASTERISK-22084</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch changes ARI bridging to allow other channel operations to
happen while the channel is bridged.
ARI channel operations are designed to queue up and execute
sequentially. This meant, though, that while a channel was bridged,
any other channel operations would queue up and execute only after the
channel left the bridge.
This patch changes ARI bridging so that channel commands can execute
while the channel is bridged. For most operations, things simply work
as expected. The one thing that ended up being a bit odd is recording.
The current recording implementation will fail when one attempts to
record a channel that's in a bridge. Note that the bridge itself may
be recording; it's recording a specific channel in the bridge that
fails. While this is an annoying limitation, channel recording is
still very useful for use cases such as voice mail, and bridge
recording makes up much of the difference for other use cases.
We may add a /monitor control for channels, which can start a
MixMonitor on a specific channel. But that would be another patch.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">* Played to channel
* Recording to channel
* Put channel in bridge
* Played to channel
* Recorded from channel
* Played to bridge
* Hungup channel from ARI
* Hungup channel from client
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/res/ari/resource_bridges.c <span style="color: grey">(395904)</span></li>
<li>/trunk/include/asterisk/stasis_app_impl.h <span style="color: grey">(395904)</span></li>
<li>/trunk/include/asterisk/stasis_app.h <span style="color: grey">(395904)</span></li>
<li>/trunk/include/asterisk/bridge_internal.h <span style="color: grey">(395904)</span></li>
<li>/trunk/include/asterisk/bridge_features.h <span style="color: grey">(395904)</span></li>
<li>/trunk/res/res_stasis.c <span style="color: grey">(395904)</span></li>
<li>/trunk/res/res_stasis_bridge_add.c <span style="color: grey">(395904)</span></li>
<li>/trunk/res/res_stasis_bridge_add.exports.in <span style="color: grey">(395904)</span></li>
<li>/trunk/res/res_stasis_playback.c <span style="color: grey">(395904)</span></li>
<li>/trunk/res/res_stasis_recording.c <span style="color: grey">(395904)</span></li>
<li>/trunk/res/stasis/control.h <span style="color: grey">(395904)</span></li>
<li>/trunk/res/stasis/control.c <span style="color: grey">(395904)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2726/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>