<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2713/">https://reviewboard.asterisk.org/r/2713/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers, kmoore, Matt Jordan, and rmudgett.</div>
<div>By jrose.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-22209">ASTERISK-22209</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Prior to this patch, using CHANNEL(dtmf_features) to set features on a channel would be overridden when using certain applications that bridge calls. This patch fixes Dial and Queue so that they leave existing DTMF features already set on the channel's feature datastore in tact and simply append their requested features.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Predial handlers were used to append Transfer and Record features to both the caller and callee. Dial was used to call SIP/B with the parking feature enabled on the caller end only. This worked as anticipated with the caller having access to all three features while the callee had access to transfer and record features, but not parking.
A similar test was done against queues, but no predial handlers were used and instead the DTMF features were only set on the channel in the dialplan. But in general this worked the same way. Features applied with the queue application options were mixed with the existing features set with the CHANNEL(dtmf_features) function.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/include/asterisk/bridge_basic.h <span style="color: grey">(395701)</span></li>
<li>/trunk/main/bridge_basic.c <span style="color: grey">(395701)</span></li>
<li>/trunk/main/features.c <span style="color: grey">(395701)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2713/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>