<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/2693/">https://reviewboard.asterisk.org/r/2693/</a>
     </td>
    </tr>
   </table>
   <br />










<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
 <p style="margin-top: 0;">On July 25th, 2013, 10:29 a.m. CDT, <b>opticron</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
  



<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="https://reviewboard.asterisk.org/r/2693/diff/1/?file=42421#file42421line21" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/res/stasis_recording/stored.c</a>
    <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>



 
 

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
    <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">21</font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cm"> * \brief Stored file operations for Stasis</span></pre></td>
  </tr>

 </tbody>

</table>

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This appears to be a media indexer of sorts. Was there any reason not to use the one we already have?</pre>
 </blockquote>





</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It didn&#39;t seem appropriate. Specifically, the need for explicitly
updating the index as the recordings/registered formats changes does
not play well with recordings.

There were a few other features that didn&#39;t fit well, either.
Description processing does not apply. Neither does variants.
Multi-format barely applies.

Actually...

If I modify the indexer to better handle the recordings directory
(basically, to build the index on-demand instead of eagerly), it would
probably work. I&#39;ll give that a go.</pre>
<br />




<p>- David</p>


<br />
<p>On July 23rd, 2013, 11:11 a.m. CDT, David Lee wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Asterisk Developers.</div>
<div>By David Lee.</div>


<p style="color: grey;"><i>Updated July 23, 2013, 11:11 a.m.</i></p>







<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="https://issues.asterisk.org/jira/browse/ASTERISK-21582">ASTERISK-21582</a>


</div>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch implements the ARI API&#39;s for stored recordings. While the
original task only specified deleting a recording, it was simple
enough to implement the GET for all recordings, and for an individual
recording.

The recording playback operation was modified to use the same code for
accessing the recording as the REST API, so that they will behave
consistently.

There were several problems with the api-docs that were also fixed,
bringing the ARI spec in line with the implementation. There were some
&#39;wishful thinking&#39; fields on the stored recording model (duration and
timestamp) that were removed, because I ended up not implementing a
metadata file to go along with the recording to store such information.

The GET /recordings/live operation was removed, since it&#39;s not really
that useful to get a list of all recordings that are currently going
on in the system. (At least, if we did that, we&#39;d probably want to
also list all of the current playbacks. Which seems weird.)</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Used Swagger-UI to poke around the API. Verified that you couldn&#39;t
delete anything outside the recording&#39;s directory.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/include/asterisk/stasis_app_recording.h <span style="color: grey">(395154)</span></li>

 <li>/trunk/res/Makefile <span style="color: grey">(395154)</span></li>

 <li>/trunk/res/res_stasis_http_recordings.c <span style="color: grey">(395154)</span></li>

 <li>/trunk/res/res_stasis_playback.c <span style="color: grey">(395154)</span></li>

 <li>/trunk/res/res_stasis_recording.c <span style="color: grey">(395154)</span></li>

 <li>/trunk/res/stasis_http/ari_model_validators.h <span style="color: grey">(395154)</span></li>

 <li>/trunk/res/stasis_http/ari_model_validators.c <span style="color: grey">(395154)</span></li>

 <li>/trunk/res/stasis_http/resource_recordings.h <span style="color: grey">(395154)</span></li>

 <li>/trunk/res/stasis_http/resource_recordings.c <span style="color: grey">(395154)</span></li>

 <li>/trunk/res/stasis_recording/stored.c <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/trunk/rest-api/api-docs/recordings.json <span style="color: grey">(395154)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/2693/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>








  </div>
 </body>
</html>