<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2680/">https://reviewboard.asterisk.org/r/2680/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 18th, 2013, 2:17 p.m. UTC, <b>Joshua Colp</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/2680/diff/1/?file=41526#file41526line271" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/res/stasis/control.c</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">271</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="n">ast_free</span><span class="p">(</span><span class="n">moh_class</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This exposes an implementation detail of the caller here, free it there instead.</pre>
</blockquote>
<p>On July 18th, 2013, 4:10 p.m. UTC, <b>jrose</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Oi, this is tricky. The caller is going to be a very generic command executor that works asynchronously from the provider of the data... and it doesn't currently take a desctructor of any kind. In retrospect, it really probably should.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ah yeah, I keep forgetting the asyncness. It's fine then.</pre>
<br />
<p>- Joshua</p>
<br />
<p>On July 16th, 2013, 8:53 p.m. UTC, jrose wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers, David Lee and Matt Jordan.</div>
<div>By jrose.</div>
<p style="color: grey;"><i>Updated July 16, 2013, 8:53 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-21974">ASTERISK-21974</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This solves half of the issue.
mohStartChannel(channel, mohclass) - Play music on hold of the specified class to the requested channel. May be interrupted by other media requests such as playOnChannel.
mohStop(channel) - Stop playing music on hold for the requested channel.
This patch is pretty simple, so I don't think there will be an issue with it.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Started music on hold without the mohclass arg and with the mohclass arg. Observed how it would react if mohstart were used with one class and then switched to another. The music on hold would restart with the new class as anticipated.
Tested stop music on hold with and without music on hold playing. If it's playing, it stops as one would anticipate and if it's not playing, nothing happens. Nothing too irregular there.
Tested both of these operations while the channel is in a bridge. Didn't work. Oh no. Well, I talked with Matt about it after finding out the same thing happens with all media playback operations in ARI and he says this is a known bug outside the scope of this problem..</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/include/asterisk/stasis_app.h <span style="color: grey">(394458)</span></li>
<li>/trunk/res/res_stasis_http_channels.c <span style="color: grey">(394458)</span></li>
<li>/trunk/res/stasis/control.c <span style="color: grey">(394458)</span></li>
<li>/trunk/res/stasis_http/resource_channels.h <span style="color: grey">(394458)</span></li>
<li>/trunk/res/stasis_http/resource_channels.c <span style="color: grey">(394458)</span></li>
<li>/trunk/rest-api/api-docs/channels.json <span style="color: grey">(394458)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2680/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>