<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2679/">https://reviewboard.asterisk.org/r/2679/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks OK to me.</pre>
<br />
<p>- rmudgett</p>
<br />
<p>On July 17th, 2013, 3:30 p.m. UTC, jrose wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers, Matt Jordan and rmudgett.</div>
<div>By jrose.</div>
<p style="color: grey;"><i>Updated July 17, 2013, 3:30 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-21923">ASTERISK-21923</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">First, the arguments to app_bridgewait are changed by this patch.
Before it was just bridgewait(options)
Now it's bridgewait(role,options)
Combined with the named waiting bridge containers patch, this will soon become
bridgewait(name,role,options)
The announcer option and the various idle mode options have been squashed. Now the role (announcer or participant) is specified in the role argument (defaulting to participant) while how participants act while idling in the holding bridge is set by the 'e' option which can specify an entertainment method.
New entertainment methods have been added to quell the bugbug comments. The 'e' option can now specify the following:
s - use a silence generator
h - Issue hold indications to be handled by the channel driver (respects MOH class argument)
n - provide no entertainment (used to be the default)
in addition to the existing:
m - Play music on hold directly (default) (respects MOH class argument)
r - Ring ring
Hopefully these changes make the app more self-explanatory to use since it isn't possible to use conflicting options now.
Between this review and https://reviewboard.asterisk.org/r/2642/diff/#index_header all BUGBUG comments in app_bridgewait should be quelled.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">* Tested all new entertainment methods to make sure they produced the anticipated audio (or just RTP in the case of silence and nothing in the case of nothing)
* Tested all options to BridgeWait to make sure they didn't break
* Tested to make sure roles were applied properly and that unknown roles would be appropriately rejected.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/apps/app_bridgewait.c <span style="color: grey">(394249)</span></li>
<li>/trunk/bridges/bridge_holding.c <span style="color: grey">(394249)</span></li>
<li>/trunk/main/bridging_roles.c <span style="color: grey">(394249)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2679/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>