<div dir="ltr"><br><div class="gmail_extra"><div class="gmail_quote">On Sat, Jul 13, 2013 at 3:27 PM, Paul Belanger <span dir="ltr"><<a href="mailto:paul.belanger@polybeacon.com" target="_blank">paul.belanger@polybeacon.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">On 13-07-13 03:17 PM, Tzafrir Cohen wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
On Fri, Jul 12, 2013 at 11:30:53PM -0500, Jeffrey Ollie wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
On Fri, Jul 12, 2013 at 9:55 PM, Matthew Jordan <<a href="mailto:mjordan@digium.com" target="_blank">mjordan@digium.com</a>> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Because pjproject itself embeds a number of third party libraries, getting<br>
pjproject properly configured for a distribution/environment can be a bit<br>
tricky. We've taken the current findings and issues that people have run<br>
into and put together a page on the Asterisk wiki here:<br>
</blockquote>
<br>
Sigh... I know that Asterisk has a long history of embedding<br>
third-party libraries, but for me to seriously consider packaging<br>
pjproject/pjsip for Fedora everything in the third-party directory has<br>
got to go.<br>
<br>
First off, there's MP3 related code in there. Even though it doesn't<br>
directly include any MP3 encoding/decoding code it's just not a battle<br>
worth dealing with. Another oddity is that the code only looks like<br>
it works on Windows by loading a LAME .dll file. In any case, adding<br>
MP3 support to a project needs to be dealt with through a generic<br>
plugin architecture (much how like Asterisk deals with codec support<br>
now).<br>
</blockquote>
<br>
[snip a number of other similar issues]<br>
<br>
Those are all issues that should be taken to pjproject's upstream. What<br>
should be fixed is that the configure script should allow (allow?<br>
default to?) using system copies for all of those libraries.<br>
<br>
Speaking of upstream, any progress with getting the code from the Gitub<br>
branch merged Upstream?<br>
<br>
</blockquote></div>
I second this, I keep asking in passing if any work as been done on this front, but seem to get 'more important things to do' reply.<br>
<br>
I'm happy to see we did remove pjproject from asterisk, but I'm equally concerned we aren't going to get the patch set merge upstream in time and have created an unnecessary fork.<div class="im HOEnZb"><br></div>
</blockquote><div><br></div><div style>Well, you got that answer for two reasons:</div><div style><br></div><div style>(1) There really *were* more important things to be doing. It wouldn't have done us any good to push changes up stream for pjproject and have Asterisk not be able to use pjproject in a satisfactory manner.</div>
<div style><br></div><div style>(2) As I said in my original e-mail, we haven't yet tested the build system sufficiently. Testing it on CentOS 6 and a couple dev boxes is not adequate. As a person who also has to deal with receiving patches to an open source project, I'd be a little miffed if I got a bunch of half-tested changes to my project tossed at me. We owe the Asterisk project - and the maintainers of pjproject - the respect to make sure that the changes are correct and sufficient.</div>
<div style><br></div><div style>That being said, Yes - we've been in contact and they've informed us how to send the patches to them for inclusion.</div><div style><br></div><div style>But before we do that, I really want to make sure that the modifications to the build system are the best they can be.</div>
</div><div><br></div><div style>Matt</div><div style><br></div>-- <br><div dir="ltr"><div>Matthew Jordan<br></div><div>Digium, Inc. | Engineering Manager</div><div>445 Jan Davis Drive NW - Huntsville, AL 35806 - USA</div>
<div>Check us out at: <a href="http://digium.com" target="_blank">http://digium.com</a> & <a href="http://asterisk.org" target="_blank">http://asterisk.org</a></div></div>
</div></div>