<div dir="ltr"><br><div class="gmail_extra"><div class="gmail_quote">On Sat, Jul 6, 2013 at 7:07 AM, Oron Peled <span dir="ltr"><<a href="mailto:oron.peled@xorcom.com" target="_blank">oron.peled@xorcom.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><u></u>
<div style="font-family:'Sans Serif';font-size:12pt;font-weight:400;font-style:normal">
<p style="margin:0px;text-indent:0px">Hi,</p>
<p style="margin:0px;text-indent:0px"> </p>
<p style="margin:0px;text-indent:0px"><span style="text-decoration:underline">Today's Asterisk+DAHDI state:</span></p>
<ul style="margin-top:0px;margin-bottom:0px;margin-right:0px"><li style="margin:12px 0px 0px;text-indent:0px">If a single channel/span breaks...</li>
<li style="margin:0px;text-indent:0px">On the next asterisk restart -- no DAHDI channels at all!</li>
<li style="margin:0px 0px 12px;text-indent:0px">Is it acceptable in 2013?</li></ul>
<p style="margin:0px;text-indent:0px"> </p>
<p style="margin:0px;text-indent:0px">This could have been fixed for years.</p>
<p style="margin:0px;text-indent:0px"> </p>
<p style="margin:0px;text-indent:0px"><span style="text-decoration:underline">What happened on the DAHDI side?</span></p>
<ul style="margin-top:0px;margin-bottom:0px;margin-right:0px"><li style="margin:12px 0px 0px;text-indent:0px">In <a href="http://lists.digium.com/pipermail/asterisk-dev/2008-July/033805.html" target="_blank"><span style="text-decoration:underline;color:rgb(0,87,174)">2008</span></a> this problem was presented, with proposed solution.</li>
<li style="margin:0px;text-indent:0px">Few months later we had a <a href="http://svnview.digium.com/svn/dahdi?view=revision&revision=5443" target="_blank"><span style="text-decoration:underline;color:rgb(0,87,174)">prototype</span></a> of the DAHDI side.</li>
<li style="margin:0px;text-indent:0px">Tried to revive interest in <a href="https://gitorious.org/asterisk-tools/dahdi-linux/commit/6e5f2bb05fd309bacab570c80e6304b487d9c19b" target="_blank"><span style="text-decoration:underline;color:rgb(0,87,174)">2010</span></a>.</li>
<li style="margin:0px;text-indent:0px">In 2011 Shaun Raffle started a big revamp of DAHDI in different direction. This resulted in the <a href="http://lists.digium.com/pipermail/asterisk-dev/2011-October/051954.html" target="_blank"><span style="text-decoration:underline;color:rgb(0,87,174)">pinned-spans</span></a> scheme which was part of DAHDI-<span style="font-weight:600">2.6.0</span>.</li>
<li style="margin:0px;text-indent:0px">Since Nov-2011, it also included the required fixes for DAHDI-tools (see the dahdi_cfg '-S<span>' and '-C<chan_list>' options).</li>
<li style="margin:0px 0px 12px;text-indent:0px">Which means DAHDI is "ready" -- each channel/span may be handled independently of the others.</li></ul>
<p style="margin:0px;text-indent:0px"><span style="text-decoration:underline">What happened in Asterisk?</span></p>
<ul style="margin-top:0px;margin-bottom:0px;margin-right:0px"><li style="margin:12px 0px 0px;text-indent:0px">Dynamic channel removal (DAHDI_EVENT_REMOVED)was added some eons ago (in the Zaptel days).</li>
<li style="margin:12px 0px 0px;text-indent:0px">It had a bug with D-Channels. Tzafrir uploaded a fix to <a href="https://reviewboard.asterisk.org/r/726/" target="_blank"><span style="text-decoration:underline;color:rgb(0,87,174)">review-board (726)</span></a> some 3 years ago -- it still lingers there instead of being applied to all supported asterisk versions.</li>
<li style="margin:0px;text-indent:0px">Dynamic channel addition code was uploaded to <a href="https://reviewboard.asterisk.org/r/1598/" target="_blank"><span style="text-decoration:underline;color:rgb(0,87,174)">review-board (1598)</span></a> in Nov-2011 and keeps waiting there...</li>
<li style="margin:0px;text-indent:0px">With these patches, Asterisk+DAHDI is fully dynamic, where we can add/remove channels and spans at run-time without affecting the PBX.</li>
<li style="margin:0px 0px 12px;text-indent:0px">But non of this is committed to trunk :-(</li></ul>
<p style="margin:0px;text-indent:0px"> </p>
<p style="margin:0px;text-indent:0px">So with all the multi-year effort to solve this problem, we are still in square-one.</p>
<p style="margin:0px;text-indent:0px"> </p>
<p style="margin:0px;text-indent:0px">Releasing Asterisk 12 in this state is a major failure in my book.</p>
<p style="margin:12px 0px 0px;text-indent:0px">Are your customers happy when a single channel failure make the whole PBX drop dead? If not, why don't you review those patches?</p>
<p style="margin:0px;text-indent:0px"> </p>
<p style="margin:0px;text-indent:0px">Sorry for the not-so-happy tone, but...</p>
<p style="margin:0px;text-indent:0px"> </p>
<p style="margin:0px;text-indent:0px"><br></p></div></blockquote><div><br></div><div class="gmail_extra"><br class="">Hi Oron!</div><div class="gmail_extra"><br></div><div class="gmail_extra">So, I'm sorry no one has reviewed Tzafrir's code. It's never good when a patch is written, gets put up on Review Board, is reviewed and updated, but then don't receive any additional feedback. Sometimes folks in the developer community just need a poke in #asterisk-dev or on the asterisk-dev mailing list to remind them to look at a particular patch - particularly when it may be in an area of Asterisk that they aren't personally familiar with. I can certainly ask someone to look at the patches to try and get them moving along again.</div>
<div class="gmail_extra"><br></div><div class="gmail_extra">As far as Asterisk 12 goes:</div><div class="gmail_extra"><br></div><div class="gmail_extra">* Since the patch is up on Review Board - and Tzafrir is certainly engaged on the patches! - I don't see any problem with working to get these patches in for Asterisk 12.</div>
<div class="gmail_extra">* That being said, we set priorities for Asterisk 12 almost a year ago - and we're now roughly three weeks out from feature freeze. If this particular problem was mentioned at AstriDevCon, it certainly isn't in my notes, which have been up on the wiki for quite some time and were distributed via the asterisk-dev list - nor is it in the notes for the AstriDevCon for Asterisk 11, nor the notes for the AstriDevCon for Asterisk 10. In the future, if you want to make sure that something is "on the radar" for the Asterisk project, it would be good to bring it up in that meeting so that the entire development community is aware of the feature and can discuss making it a priority for the upcoming version.</div>
<div class="gmail_extra"><br></div><div class="gmail_extra">Thanks!</div><div class="gmail_extra"><br></div><div>Matt </div></div><div><br></div>-- <br><div dir="ltr"><div>Matthew Jordan<br></div><div>Digium, Inc. | Engineering Manager</div>
<div>445 Jan Davis Drive NW - Huntsville, AL 35806 - USA</div><div>Check us out at: <a href="http://digium.com" target="_blank">http://digium.com</a> & <a href="http://asterisk.org" target="_blank">http://asterisk.org</a></div>
</div>
</div></div>