<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2633/">https://reviewboard.asterisk.org/r/2633/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm not a huge fan of this approach. It feels unclean and hackish to use the role for determining whether to filter things. I think I would prefer having both a channel flag and this callback. You get the informational aspect of the role information, but also an explicit ability to filter a channel and they each have their clearly defined purpose.</pre>
<br />
<p>- Joshua</p>
<br />
<p>On June 21st, 2013, 12:56 p.m. UTC, opticron wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By opticron.</div>
<p style="color: grey;"><i>Updated June 21, 2013, 12:56 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-21873">ASTERISK-21873</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This adds a new function pointer to the channel tech which determines whether a channel is fit for external consumption. Examples of channels that would not be fit for external consumption include the announcement and recording channels used by confbridge which are the only two marked as such by this patch.
A lot of this ended up being cleanup to ensure callers of various functions could handle a NULL return.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ran through CDR unit tests.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/apps/confbridge/conf_chan_announce.c <span style="color: grey">(392407)</span></li>
<li>trunk/apps/confbridge/conf_chan_record.c <span style="color: grey">(392407)</span></li>
<li>trunk/apps/confbridge/confbridge_manager.c <span style="color: grey">(392407)</span></li>
<li>trunk/include/asterisk/channel.h <span style="color: grey">(392407)</span></li>
<li>trunk/include/asterisk/stasis_channels.h <span style="color: grey">(392407)</span></li>
<li>trunk/main/cdr.c <span style="color: grey">(392407)</span></li>
<li>trunk/main/cel.c <span style="color: grey">(392407)</span></li>
<li>trunk/main/manager_bridging.c <span style="color: grey">(392407)</span></li>
<li>trunk/main/manager_channels.c <span style="color: grey">(392407)</span></li>
<li>trunk/main/stasis_channels.c <span style="color: grey">(392407)</span></li>
<li>trunk/res/parking/parking_manager.c <span style="color: grey">(392407)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2633/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>