<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2649/">https://reviewboard.asterisk.org/r/2649/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By David Lee.</div>
<p style="color: grey;"><i>Updated June 28, 2013, 3:03 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Addressed review feedback.
* Consolidated the allocation of the ast_http_auth object
* Cleaned up the parsing of username:password using strsep
* Allocated config objects using AO2_ALLOC_OPT_LOCK_NOLOCK
* Logging message cleanups
</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-21277">ASTERISK-21277</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adds authentication support to ARI.
Two authentication methods are supported. The first is HTTP Basic
authentication, as specified in RFC 2617[1]. The second is by simply
passing the username and password as an ?api_key query parameter
(which allows swagger-ui[2] to authenticate more easily).
ARI usernames and passwords are configured in the stasis_http.conf
file. The user may be set to `read_only`, which will prohibit the user
from issuing POST, DELETE, etc. The user's password may be specified
in either plaintext, or encrypted using the crypt() function.
Several other notes about the patch.
* A few command line commands for seeing ARI config and status were
also added.
* The configuration parsing grew big enough that I extracted it to
its own file.
[1]: http://www.ietf.org/rfc/rfc2617.txt
[2]: https://github.com/wordnik/swagger-ui</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Unit tests for crypt wrapper.
Testsuite tests for authn testing. See https://reviewboard.asterisk.org/r/2650/</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/configs/stasis_http.conf.sample <span style="color: grey">(393124)</span></li>
<li>/trunk/configure <span style="color: grey">(UNKNOWN)</span></li>
<li>/trunk/configure.ac <span style="color: grey">(393124)</span></li>
<li>/trunk/include/asterisk/autoconfig.h.in <span style="color: grey">(393124)</span></li>
<li>/trunk/include/asterisk/http.h <span style="color: grey">(393124)</span></li>
<li>/trunk/include/asterisk/utils.h <span style="color: grey">(393124)</span></li>
<li>/trunk/main/Makefile <span style="color: grey">(393124)</span></li>
<li>/trunk/main/http.c <span style="color: grey">(393124)</span></li>
<li>/trunk/main/utils.c <span style="color: grey">(393124)</span></li>
<li>/trunk/makeopts.in <span style="color: grey">(393124)</span></li>
<li>/trunk/res/Makefile <span style="color: grey">(393124)</span></li>
<li>/trunk/res/res_stasis_http.c <span style="color: grey">(393124)</span></li>
<li>/trunk/res/stasis_http/cli.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/res/stasis_http/config.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/res/stasis_http/internal.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/tests/test_utils.c <span style="color: grey">(393124)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2649/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>