<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2592/">https://reviewboard.asterisk.org/r/2592/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 24th, 2013, 9:10 p.m. UTC, <b>Matt Jordan</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">One of the primary reasons for having tests is to verify functionality that shouldn't change between versions. By having a test that runs against both 11 and 12, we can ensure that regardless of AMI event differences, configuration changes, etc. - the basic functionality still works. I really think this test needs to run against 11 and 12, which will probably change how you structure this test, since the AMI events have changed so significantly.
{quote}
This test is based roughly on the directed pickup application test (but that test doesn't really work anymore).
{quote}
That's a sign that something changed. Either that test is broken, or Pickup has changed enough that valid configurations will now break.</pre>
</blockquote>
<p>On June 24th, 2013, 10:45 p.m. UTC, <b>jrose</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Pickup as a feature is distinct from app_pickup, which is what this was testing. It doesn't really have anything to do with the work I was doing for the Pickup feature. I've already fixed that test though, the problem was entirely with AMI events... specifically the difference between Bridge and BridgeEnter.</pre>
</blockquote>
<p>On June 24th, 2013, 10:53 p.m. UTC, <b>jrose</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Oh, also Dial and DialBegin.</pre>
</blockquote>
<p>On June 24th, 2013, 11:41 p.m. UTC, <b>Matt Jordan</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm aware that this was testing the feature, not the application - my capitalization of "Pickup" was simply a poor choice of proper nouns.
Regardless, we've changed how things get bridged together, as well as when they do. We've changed masquerades, if for no other reason than a lot of code that used to call it no longer does. We've changed the features code that causes a pickup to occur. I think having a test that covers the pickup functionality in both 11 and trunk is appropriate.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Oh yeah, no argument there. I'm just saying the test that this was based on, the one that was failing for 12 when I wrote this one... that was for the application.</pre>
<br />
<p>- jrose</p>
<br />
<p>On June 5th, 2013, 4:02 p.m. UTC, jrose wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers, kmoore and Matt Jordan.</div>
<div>By jrose.</div>
<p style="color: grey;"><i>Updated June 5, 2013, 4:02 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-21544">ASTERISK-21544</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
testsuite
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This test is based roughly on the directed pickup application test (but that test doesn't really work anymore). Basically it does the following:
1) A local channel is originated to an extension that will dial a SIP peer (faker). This SIP peer points to an unused address, so it won't answer.
2) Once the dial starts, Asterisk 2 dials Asterisk 1 via SIP to extension *8 (the pickup extension assigned in features.conf)
3) At this point the SIP channel on Asterisk 2 (sip_receive is its peername on Asterisk 1) should answer the call made by the local channel since faker is in a callgroup set for use by sip_receive. Both channels will then enter a simple bridge together.
Once https://reviewboard.asterisk.org/r/2582/ is committed I can also add the pickupsound being played as a condition for completing the test.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ran it a few times and made sure what was happening matched with log messages after the test was over. Made sure all pass conditions were actually met as well.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/asterisk/trunk/tests/feature_call_pickup/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/feature_call_pickup/configs/ast1/features.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/feature_call_pickup/configs/ast1/sip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/feature_call_pickup/configs/ast2/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/feature_call_pickup/configs/ast2/sip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/feature_call_pickup/run-test <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/feature_call_pickup/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2592/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>