<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2601/">https://reviewboard.asterisk.org/r/2601/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/2601/diff/1/?file=39239#file39239line653" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/channels/chan_gulp.c</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">653</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="k">if</span> <span class="p">(</span><span class="n">endpoint_snapshot</span><span class="o">-></span><span class="n">num_channels</span> <span class="o">&&</span> <span class="p">(</span><span class="n">caching_topic</span> <span class="o">=</span> <span class="n">ast_channel_topic_all_cached</span><span class="p">()))</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">reduce indentation
something like;
if (!endpoint_snapshot->num_channels || !(caching_topic = ast_channel_topic_all_cached())) {
return state;
}
</pre>
</div>
<br />
<p>- Alec</p>
<br />
<p>On June 7th, 2013, 12:55 p.m. UTC, Joshua Colp wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Joshua Colp.</div>
<p style="color: grey;"><i>Updated June 7, 2013, 12:55 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The attached changes implement the following:
1. Migrates the PeerStatus manager event to using Stasis.
Anything generating the PeerStatus event now does so by creating a stasis message and attaching a JSON blob.
2. Adds internal endpoints to some channel drivers.
To allow the above to occur some channel drivers now have endpoints on them.
3. chan_pjsip endpoint support.
chan_pjsip will now create a persistent endpoint which is used for the below device state support.
4. chan_pjsip devicestate support.
chan_pjsip now has device state support! Unlike other channel drivers this uses stasis to derive the current device state based on endpoint state and active channels.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Exercised the various channel drivers to ensure that the manager events are going out.
Placed tons of calls with different scenarios with chan_pjsip to ensure that the device state changes to what is expected, and it does.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/channels/chan_gulp.c <span style="color: grey">(390667)</span></li>
<li>/trunk/channels/chan_iax2.c <span style="color: grey">(390667)</span></li>
<li>/trunk/channels/chan_sip.c <span style="color: grey">(390667)</span></li>
<li>/trunk/channels/chan_skinny.c <span style="color: grey">(390667)</span></li>
<li>/trunk/include/asterisk/manager.h <span style="color: grey">(390667)</span></li>
<li>/trunk/include/asterisk/res_sip.h <span style="color: grey">(390667)</span></li>
<li>/trunk/include/asterisk/stasis_endpoints.h <span style="color: grey">(390667)</span></li>
<li>/trunk/main/manager.c <span style="color: grey">(390667)</span></li>
<li>/trunk/main/manager_endpoints.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/main/stasis_endpoints.c <span style="color: grey">(390667)</span></li>
<li>/trunk/res/res_sip.c <span style="color: grey">(390667)</span></li>
<li>/trunk/res/res_sip/sip_configuration.c <span style="color: grey">(390667)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2601/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>