<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2579/">https://reviewboard.asterisk.org/r/2579/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 31st, 2013, 4:44 a.m. UTC, <b>opticron</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm not so sure that NULL-safety on a ao2_ref variant is such a good idea when ao2_ref is not NULL-safe.
Be ready to lose a merge race on the confbridge changes.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm with Kinsey on this one. While I can certainly see why you're doing it - checking each return and returning NULL and on the success path bumping it by one and returning the same pointer is a bit tedious - it feels like this could be abused. In general, people shouldn't be ref bumping something that is NULL.</pre>
<br />
<p>- Matt</p>
<br />
<p>On May 31st, 2013, 3:42 a.m. UTC, David Lee wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers, Matt Jordan and Jason Parker.</div>
<div>By David Lee.</div>
<p style="color: grey;"><i>Updated May 31, 2013, 3:42 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-21817">ASTERISK-21817</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When a Stasis message type is defined in a loadable module, handling
those messages for AMI and res_stasis events can be cumbersome.
This patch adds a vtable to stasis_message_type, with to_ami and
to_json virtual functions. These allow messages to be handled
abstractly without putting module-specific code in core.
As an example, the VarSet AMI event was refactored to use the to_ami
virtual function.
Additionally, I finally got tired of the boilerplate incrementing AO2
refcounts, so I added an ao2_ref1() macro, which is NULL safe and
returns the object.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Unit tests.
Verified that the VarSet event still looked the way it ought to.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/apps/confbridge/confbridge_manager.c <span style="color: grey">(390151)</span></li>
<li>/trunk/include/asterisk/astobj2.h <span style="color: grey">(390151)</span></li>
<li>/trunk/include/asterisk/manager.h <span style="color: grey">(390151)</span></li>
<li>/trunk/include/asterisk/stasis.h <span style="color: grey">(390151)</span></li>
<li>/trunk/main/manager.c <span style="color: grey">(390151)</span></li>
<li>/trunk/main/manager_channels.c <span style="color: grey">(390151)</span></li>
<li>/trunk/main/parking.c <span style="color: grey">(390151)</span></li>
<li>/trunk/main/stasis_channels.c <span style="color: grey">(390151)</span></li>
<li>/trunk/main/stasis_message.c <span style="color: grey">(390151)</span></li>
<li>/trunk/tests/test_astobj2.c <span style="color: grey">(390151)</span></li>
<li>/trunk/tests/test_stasis.c <span style="color: grey">(390151)</span></li>
<li>/trunk/tests/test_stasis_channels.c <span style="color: grey">(390151)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2579/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>