<div dir="ltr">Hi Lorenzo, <div><br></div><div>I tried applying the patch and running bootstrap.sh against Asterisk 11.1.2, just to use that as a sanity check, and I still see the same issues:<div><br></div><div><div>root@ip-10-188-135-200:/mnt/src/asterisk-11.1.2# ./bootstrap.sh </div>
<div>Generating the configure script ...</div><div><a href="http://configure.ac:102">configure.ac:102</a>: error: possibly undefined macro: AC_DEFINE</div><div> If this token and others are legitimate, please use m4_pattern_allow.</div>
<div> See the Autoconf documentation.</div><div>root@ip-10-188-135-200:/mnt/src/asterisk-11.1.2# </div></div><div><br></div><div style>How did you install libopus? I grabbed 1.0.2, the latest version, from here? <a href="http://www.opus-codec.org/downloads/">http://www.opus-codec.org/downloads/</a> and then followed their instructions for building and installing it. </div>
</div><div style><br></div><div style>James</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, May 27, 2013 at 5:04 PM, James Mortensen <span dir="ltr"><<a href="mailto:james.mortensen@voicecurve.com" target="_blank">james.mortensen@voicecurve.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Also, I want to add that applying the patch is successful, but due to the version differences there is some offset:<div>
<br></div><div><div>root@ip-10-188-135-200:/mnt/src/asterisk-11.4.0# patch -p1 -u < asterisk_opus+vp8.diff</div><div class="im">
<div>patching file build_tools/<a href="http://menuselect-deps.in" target="_blank">menuselect-deps.in</a></div><div>patching file channels/chan_sip.c</div><div>Hunk #1 succeeded at 7757 (offset 33 lines).</div><div>Hunk #2 succeeded at 11045 (offset 46 lines).</div>
<div>Hunk #3 succeeded at 11084 (offset 46 lines).</div><div>Hunk #4 succeeded at 11151 (offset 46 lines).</div><div>Hunk #5 succeeded at 12756 (offset 107 lines).</div><div>Hunk #6 succeeded at 12789 (offset 107 lines).</div>
</div><div>patching file codecs/codec_opus.c</div><div>patching file codecs/ex_opus.h</div><div>patching file <a href="http://configure.ac" target="_blank">configure.ac</a></div><div>Hunk #2 succeeded at 2119 (offset 32 lines).</div>
<div>patching file formats/format_vp8.c</div>
<div>patching file include/asterisk/format.h</div><div>patching file main/channel.c</div><div>Hunk #1 succeeded at 914 (offset 5 lines).</div><div>patching file main/format.c</div><div>Hunk #5 succeeded at 1083 (offset -1 lines).</div>
<div>patching file main/frame.c</div><div>patching file main/rtp_engine.c</div><div>Hunk #1 succeeded at 2289 (offset 21 lines).</div><div>Hunk #2 succeeded at 2333 (offset 21 lines).</div><div>patching file <a href="http://makeopts.in" target="_blank">makeopts.in</a></div>
<div>Hunk #1 succeeded at 262 (offset 1 line).</div><div>patching file res/res_rtp_asterisk.c</div><div>Hunk #2 succeeded at 349 (offset 6 lines).</div><div>Hunk #3 succeeded at 2620 (offset 16 lines).</div><div>Hunk #4 succeeded at 2706 (offset 16 lines).</div>
</div><div><br></div><div><br></div><div>From what I understand, as long as there are no errors, the patch should theoretically have been applied. Hope this helps!</div><span class="HOEnZb"><font color="#888888"><div><br>
</div><div>James</div></font></span></div><div class="HOEnZb"><div class="h5">
<div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, May 27, 2013 at 4:53 PM, James Mortensen <span dir="ltr"><<a href="mailto:james.mortensen@voicecurve.com" target="_blank">james.mortensen@voicecurve.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi Lorenzo, <div><br></div><div>Please disregard my last set of issues. The problem was something to do with an unrelated server bug. I'm still trying to get the patch to work on 11.4.0 since that is the latest stable release of Asterisk, and I'm hoping I can provide you with enough helpful information for you to move forward.</div>
<div><br></div><div>When I run the bootstrap.sh command to generate the configure script, I did see the following error:</div><div><br></div><div><div># ./bootstrap.sh </div><div>Generating the configure script ...</div>
<div><a href="http://configure.ac:102" target="_blank">configure.ac:102</a>: error: possibly undefined macro: AC_DEFINE</div><div> If this token and others are legitimate, please use m4_pattern_allow.</div><div> See the Autoconf documentation.</div>
<div><br></div><div>I ran apt-get update && apt-get upgrade and then reran the bootstrap.sh, which was a success. I'm not sure if that mattered or not, but there were no warnings or errors the second time around.</div>
</div><div><br></div><div>But then running the configure script, I get the following compile errors:</div><div><br></div><div><div>checking if "int foo = DAHDI_ECHOCANCEL_FAX_MODE" compiles using dahdi/user.h... no</div>
<div>checking for getifaddrs() support... yes</div><div>checking for timerfd support... yes</div><div>checking for gsm_create in -lgsm... no</div><div>./configure: line 17995: syntax error near unexpected token `ILBC,'</div>
<div>./configure: line 17995: ` PKG_CHECK_MODULES(ILBC, libilbc,'</div><div><br></div><div>I looked in the previous configure script, before running bootstrap.sh, and I don't see any instances of PKG_CHECK_MODULES or ILBC. That is an existing codec, I believe, so why would the opus codec require these additions?</div>
<div><br></div><div>I am wondering if you happen to see anything that might be helpful here; otherwise, I plan to continue to dig into this and move forward as best I can.</div><div><br></div><div>
Thank you, and hope this helps! </div><span><font color="#888888"><div>James</div><div><br></div><div><br></div></font></span></div><div><div><div class="gmail_extra"><br><br><div class="gmail_quote">
On Mon, May 27, 2013 at 12:45 PM, Lorenzo Miniero <span dir="ltr"><<a href="mailto:lminiero@gmail.com" target="_blank">lminiero@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">2013/5/27 James Mortensen <span dir="ltr"><<a href="mailto:james.mortensen@voicecurve.com" target="_blank">james.mortensen@voicecurve.com</a>></span><br>
<div class="gmail_extra"><div class="gmail_quote"><div><div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div><span style="color:rgb(51,51,51);font-family:Helvetica,arial,freesans,clean,sans-serif;font-size:15px;line-height:25px">In the instructions </span><font color="#333333" face="Helvetica, arial, freesans, clean, sans-serif"><span style="font-size:15.454545021057129px;line-height:25px"><a href="https://github.com/meetecho/asterisk-opus/blob/master/README.md" target="_blank">https://github.com/meetecho/asterisk-opus/blob/master/README.md</a>, we see the following:</span></font></div>
<span style="color:rgb(51,51,51);font-family:Helvetica,arial,freesans,clean,sans-serif;font-size:15px;line-height:25px"><div><span style="color:rgb(51,51,51);font-family:Helvetica,arial,freesans,clean,sans-serif;font-size:15px;line-height:25px"><br>
</span></div>"Make sure that codec_opus and format_vp8 are enabled in menuselect before going on. Besides, for better results, install the slin16 versions of the Asterisk sounds, which are not enabled by default."</span><div>
<font color="#333333" face="Helvetica, arial, freesans, clean, sans-serif"><span style="font-size:15.454545021057129px;line-height:25px"><br></span></font></div><div><font color="#333333" face="Helvetica, arial, freesans, clean, sans-serif"><span style="font-size:15.454545021057129px;line-height:25px">What part of the menuselect should we expect to find codec_opus and format_vp8? I'm trying to add this patch to Asterisk 11.4.0 and don't want to play guessing games if this isn't going to work. I checked in the "Codec Translators" section and I don't see those codec's listed.</span></font></div>
<div><font color="#333333" face="Helvetica, arial, freesans, clean, sans-serif"><span style="font-size:15.454545021057129px;line-height:25px"><br></span></font></div><div><font color="#333333" face="Helvetica, arial, freesans, clean, sans-serif"><span style="font-size:15.454545021057129px;line-height:25px">Also, if it helps, I see this when configuring opus from source:</span></font></div>
<div><font color="#333333" face="Helvetica, arial, freesans, clean, sans-serif"><span style="font-size:15.454545021057129px;line-height:25px"><br></span></font></div><div><font color="#333333" face="Helvetica, arial, freesans, clean, sans-serif"><div>
<span style="font-size:15.454545021057129px;line-height:25px">------------------------------------------------------------------------</span></div><div><span style="font-size:15.454545021057129px;line-height:25px"> opus 1.0.2: Automatic configuration OK.</span></div>
<div><span style="font-size:15.454545021057129px;line-height:25px"><br></span></div><div><span style="font-size:15.454545021057129px;line-height:25px"> Compiler support:</span></div><div><span style="font-size:15.454545021057129px;line-height:25px"><br>
</span></div><div><span style="font-size:15.454545021057129px;line-height:25px"> C99 var arrays: ................ yes</span></div><div><span style="font-size:15.454545021057129px;line-height:25px"> C99 lrintf: .................... yes</span></div>
<div><span style="font-size:15.454545021057129px;line-height:25px"> Alloca: ........................ yes</span></div><div><span style="font-size:15.454545021057129px;line-height:25px"><br></span></div><div><span style="font-size:15.454545021057129px;line-height:25px"> General configuration:</span></div>
<div><span style="font-size:15.454545021057129px;line-height:25px"><br></span></div><div><span style="font-size:15.454545021057129px;line-height:25px"> Floating point support: ........ yes</span></div><div><span style="font-size:15.454545021057129px;line-height:25px"> Fast float approximations: ..... no</span></div>
<div><span style="font-size:15.454545021057129px;line-height:25px"> Fixed point debugging: ......... no</span></div><div><span style="font-size:15.454545021057129px;line-height:25px"> Custom modes: .................. no</span></div>
<div><span style="font-size:15.454545021057129px;line-height:25px"> Assertion checking: ............ no</span></div><div><span style="font-size:15.454545021057129px;line-height:25px"> Fuzzing: ....................... no</span></div>
<div><span style="font-size:15.454545021057129px;line-height:25px"><br></span></div><div><span style="font-size:15.454545021057129px;line-height:25px"> API documentation: ............. no</span></div><div><span style="font-size:15.454545021057129px;line-height:25px">------------------------------------------------------------------------</span></div>
<div style="font-size:15.454545021057129px;line-height:25px"><br></div><div style="font-size:15.454545021057129px;line-height:25px">Opus compiled on Ubuntu 12.04 without any errors or warnings.</div><div style="font-size:15.454545021057129px;line-height:25px">
<br></div><div style="font-size:15.454545021057129px;line-height:25px">However, when patching Asterisk, I see the following:</div><div style="font-size:15.454545021057129px;line-height:25px"><br></div><div><div><span style="font-size:15.454545021057129px;line-height:25px">root@jamesasterisktest:/mnt/asteriskpersistent/src/asterisk-11.4.0# patch -p1 -u < asterisk_opus+vp8.diff</span></div>
<div><span style="font-size:15.454545021057129px;line-height:25px">patching file build_tools/<a href="http://menuselect-deps.in" target="_blank">menuselect-deps.in</a></span></div><div><span style="font-size:15.454545021057129px;line-height:25px">patching file channels/chan_sip.c</span></div>
<div><span style="font-size:15.454545021057129px;line-height:25px">Hunk #1 succeeded at 7757 (offset 33 lines).</span></div><div><span style="font-size:15.454545021057129px;line-height:25px">Hunk #2 succeeded at 11045 (offset 46 lines).</span></div>
<div><span style="font-size:15.454545021057129px;line-height:25px">Hunk #3 succeeded at 11084 (offset 46 lines).</span></div><div><span style="font-size:15.454545021057129px;line-height:25px">Hunk #4 succeeded at 11151 (offset 46 lines).</span></div>
<div><span style="font-size:15.454545021057129px;line-height:25px">Hunk #5 succeeded at 12756 (offset 107 lines).</span></div><div><span style="font-size:15.454545021057129px;line-height:25px">Hunk #6 succeeded at 12789 (offset 107 lines).</span></div>
<div><span style="font-size:15.454545021057129px;line-height:25px">patch: **** write error : No space left on device</span></div></div></font></div><div><font color="#333333" face="Helvetica, arial, freesans, clean, sans-serif"><span style="font-size:15.454545021057129px;line-height:25px"><br>
</span></font></div><div><font color="#333333" face="Helvetica, arial, freesans, clean, sans-serif"><span style="font-size:15.454545021057129px;line-height:25px">The drive has 2.3GB of available space, and the patch isn't that big. </span></font></div>
<div><font color="#333333" face="Helvetica, arial, freesans, clean, sans-serif"><span style="font-size:15.454545021057129px;line-height:25px"><br></span></font></div><div><font color="#333333" face="Helvetica, arial, freesans, clean, sans-serif"><span style="font-size:15.454545021057129px;line-height:25px">If any of this looks related to the patch issues, I'll try with 11.1.2. I just want to make sure the other pieces are in order and that I'm looking for things in menuselect in the right places.</span></font></div>
<div><font color="#333333" face="Helvetica, arial, freesans, clean, sans-serif"><span style="font-size:15.454545021057129px;line-height:25px"><br></span></font></div></div></blockquote><div><br></div><div> </div></div></div>
<div><div><span style="font-family:arial,sans-serif;font-size:13px">My guess is that the error you got prevented the patch from being completely applied: most likely neither code_opus.c nor format_vp8.c were created, and so they don't appear in menuselect. About Asterisk 11.4.0 compatibility, I'm not familiar with that version so I'm not sure if and how it would work. If the menuselect syntax has not been changed in the meanwhile it should find both the files without problems.</span><br>
</div><div><span style="font-family:arial,sans-serif;font-size:13px"><br></span></div><div><span style="font-family:arial,sans-serif;font-size:13px">Lorenzo</span></div><div><span style="font-family:arial,sans-serif;font-size:13px"><br>
</span></div></div><div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div><font color="#333333" face="Helvetica, arial, freesans, clean, sans-serif"><span style="font-size:15.454545021057129px;line-height:25px">
</span></font></div><div><font color="#333333" face="Helvetica, arial, freesans, clean, sans-serif"><span style="font-size:15.454545021057129px;line-height:25px">Thank you!<span><font color="#888888"><br clear="all">
</font></span></span></font><span><font color="#888888"><div><br></div>-- <br>
James Mortensen<br>Project Manager, VoiceCurve, Inc.<br><a href="tel:866-707-4590" value="+18667074590" target="_blank">866-707-4590</a><br><a href="mailto:james.mortensen@voicecurve.com" target="_blank">james.mortensen@voicecurve.com</a><br>
</font></span></div></div>
</blockquote></div></div><br></div></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br>James Mortensen<br>Project Manager, VoiceCurve, Inc.<br><a href="tel:866-707-4590" value="+18667074590" target="_blank">866-707-4590</a><br><a href="mailto:james.mortensen@voicecurve.com" target="_blank">james.mortensen@voicecurve.com</a><br>
</div></div></div></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br>James Mortensen<br>Project Manager, VoiceCurve, Inc.<br><a href="tel:866-707-4590" value="+18667074590" target="_blank">866-707-4590</a><br><a href="mailto:james.mortensen@voicecurve.com" target="_blank">james.mortensen@voicecurve.com</a><br>
</div>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br>James Mortensen<br>Project Manager, VoiceCurve, Inc.<br>866-707-4590<br><a href="mailto:james.mortensen@voicecurve.com" target="_blank">james.mortensen@voicecurve.com</a><br>
</div>