<div dir="ltr">2013/5/27 Tzafrir Cohen <span dir="ltr"><<a href="mailto:tzafrir.cohen@xorcom.com" target="_blank">tzafrir.cohen@xorcom.com</a>></span><br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im">On Mon, May 27, 2013 at 04:09:08PM +0200, Lorenzo Miniero wrote:<br>
> Dear all,<br>
><br>
> I've just published the patch on github:<br>
><br>
> <a href="https://github.com/meetecho/asterisk-opus" target="_blank">https://github.com/meetecho/asterisk-opus</a><br>
><br>
> The README should be quite self explainatory, but if you need any<br>
> additional info feel free to ask me.<br>
> Any feedback will be more than welcome!<br>
<br>
</div>$ diffstat asterisk-opus/asterisk_opus+vp8.diff<br>
build_tools/<a href="http://menuselect-deps.in" target="_blank">menuselect-deps.in</a> | 1<br>
channels/chan_sip.c | 91 ++++++-<br>
codecs/codec_opus.c | 529 +++++++++++++++++++++++++++++++++++++++++<br>
codecs/ex_opus.h | 35 ++<br>
<a href="http://configure.ac" target="_blank">configure.ac</a> | 3<br>
formats/format_vp8.c | 195 +++++++++++++++<br>
include/asterisk/format.h | 4<br>
main/channel.c | 2<br>
main/format.c | 16 +<br>
main/frame.c | 38 ++<br>
main/rtp_engine.c | 6<br>
<a href="http://makeopts.in" target="_blank">makeopts.in</a> | 3<br>
res/res_rtp_asterisk.c | 42 +++<br>
13 files changed, 960 insertions(+), 5 deletions(-)<br>
<br>
Any problem with including the format parts of this patch into Asterisk?<br>
Asterisk has limited support for H.264 video. I don't suppose Asterisk<br>
comes with a license for a H.264 video playback (let alone encoding).<br>
<br>
At first glance, the following parts of the patch seem to be related to<br>
formats, rather than codecs:<br>
<br>
channels/chan_sip.c | 91 ++++++-<br>
formats/format_vp8.c | 195 +++++++++++++++<br>
include/asterisk/format.h | 4<br>
main/channel.c | 2<br>
main/format.c | 16 +<br>
main/rtp_engine.c | 6<br>
res/res_rtp_asterisk.c | 42 +++<br>
<br>
Would a patch / review of those parts by Lorenzo be welcomed?<br>
<span class="HOEnZb"><font color="#888888"><br></font></span></blockquote><div><br></div><div><br></div><div style>Actually all the files have stuff related to both codecs: so the code related to Opus should be stripped from chan_sip, format, rtp_engine, etc. first in order to have them refer to VP8 only. The format_vp8.c file itself is pretty much a clone of the H.264 one, so if this one's ok I guess that one will be too.</div>
<div style><br></div><div style>Lorenzo</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="HOEnZb"><font color="#888888">
--<br>
Tzafrir Cohen<br>
icq#16849755 <a href="mailto:jabber%3Atzafrir.cohen@xorcom.com">jabber:tzafrir.cohen@xorcom.com</a><br>
<a href="tel:%2B972-50-7952406" value="+972507952406">+972-50-7952406</a> mailto:<a href="mailto:tzafrir.cohen@xorcom.com">tzafrir.cohen@xorcom.com</a><br>
<a href="http://www.xorcom.com" target="_blank">http://www.xorcom.com</a> <a href="http://iax:guest@local.xorcom.com/tzafrir" target="_blank">iax:guest@local.xorcom.com/tzafrir</a><br>
</font></span><div class="HOEnZb"><div class="h5"><br>
--<br>
_____________________________________________________________________<br>
-- Bandwidth and Colocation Provided by <a href="http://www.api-digital.com" target="_blank">http://www.api-digital.com</a> --<br>
<br>
asterisk-dev mailing list<br>
To UNSUBSCRIBE or update options visit:<br>
<a href="http://lists.digium.com/mailman/listinfo/asterisk-dev" target="_blank">http://lists.digium.com/mailman/listinfo/asterisk-dev</a><br>
</div></div></blockquote></div><br></div></div>