<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/2554/">https://reviewboard.asterisk.org/r/2554/</a>
     </td>
    </tr>
   </table>
   <br />




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Asterisk Developers.</div>
<div>By Kevin Harwell.</div>


<p style="color: grey;"><i>Updated May 24, 2013, 9:39 p.m.</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Updated per review findings.</pre>
  </td>
 </tr>
</table>





<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="https://issues.asterisk.org/jira/browse/ASTERISK-21433">ASTERISK-21433</a>


</div>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Adds support for &#39;alwaysauthreject&#39; to the new SIP channel driver.  When the &#39;alwaysauthreject&#39; option is set to &#39;yes&#39; (default) and no matching endpoint is found for the incoming request, after challenging, Asterisk will respond with a 401 Unauthorized regardless of the reason it rejects the request.

These changes also include a new global &#39;security&#39; configuration section in res_sip.conf that now includes the &#39;alwaysauthreject&#39; and ACL options.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Attempted to connect to an unknown endpoint in Asterisk and observed that it responded appropriately and with a correct 401 when &#39;alwaysauthreject&#39; was enabled.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>team/group/pimp_my_sip/include/asterisk/res_sip.h <span style="color: grey">(389750)</span></li>

 <li>team/group/pimp_my_sip/res/res_sip.c <span style="color: grey">(389750)</span></li>

 <li>team/group/pimp_my_sip/res/res_sip.exports.in <span style="color: grey">(389750)</span></li>

 <li>team/group/pimp_my_sip/res/res_sip/config_auth.c <span style="color: grey">(389750)</span></li>

 <li>team/group/pimp_my_sip/res/res_sip/config_security.c <span style="color: grey">(PRE-CREATION)</span></li>

 <li>team/group/pimp_my_sip/res/res_sip/sip_configuration.c <span style="color: grey">(389750)</span></li>

 <li>team/group/pimp_my_sip/res/res_sip/sip_distributor.c <span style="color: grey">(389750)</span></li>

 <li>team/group/pimp_my_sip/res/res_sip_acl.c <span style="color: grey">(389750)</span></li>

 <li>team/group/pimp_my_sip/res/res_sip_authenticator_digest.c <span style="color: grey">(389750)</span></li>

 <li>team/group/pimp_my_sip/res/res_sip_outbound_authenticator_digest.c <span style="color: grey">(389750)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/2554/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>




  </div>
 </body>
</html>