<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/2531/">https://reviewboard.asterisk.org/r/2531/</a>
     </td>
    </tr>
   </table>
   <br />










<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
 <p style="margin-top: 0;">On May 23rd, 2013, 9:49 a.m. CDT, <b>opticron</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
  



<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="https://reviewboard.asterisk.org/r/2531/diff/3/?file=38383#file38383line287" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/res/res_stasis_playback.c</a>
    <span style="font-weight: normal;">

     (Diff revision 3)

    </span>
   </th>
  </tr>
 </thead>



 
 

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
    <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">287</font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb">        </span><span class="n">ast_assert</span><span class="p">(</span><span class="mi">0</span><span class="p">);</span> <span class="cm">/* </span><span class="cs">TODO</span><span class="cm"> */</span></pre></td>
  </tr>

 </tbody>

</table>

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">A stub to flesh out.</pre>
 </blockquote>





</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">That&#39;s in a separate review - https://reviewboard.asterisk.org/r/2559/</pre>
<br />




<p>- David</p>


<br />
<p>On May 21st, 2013, 9:22 a.m. CDT, David Lee wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Asterisk Developers.</div>
<div>By David Lee.</div>


<p style="color: grey;"><i>Updated May 21, 2013, 9:22 a.m.</i></p>







<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="https://issues.asterisk.org/jira/browse/ASTERISK-21283">ASTERISK-21283</a>, 

 <a href="https://issues.asterisk.org/jira/browse/ASTERISK-21586">ASTERISK-21586</a>


</div>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">(depends on https://reviewboard.asterisk.org/r/2530)

This patch implements the REST API&#39;s for POST /channels/{channelId}/play
and GET /playback/{playbackId}.

This allows an external application to initiate playback of a sound on a
channel while the channel is in the Stasis application.

/play commands are issued asynchronously, and return immediately with
the URL of the associated /playback resource. Playback commands queue up,
playing in succession. The /playback resource shows the state of a
playback operation as enqueued, playing or complete. (Although the
operation will only be in the &#39;complete&#39; state for a very short time,
since it is almost immediately freed up).

(closes issue ASTERISK-21283)
(closes issue ASTERISK-21586)
Review: https://reviewboard.asterisk.org/r/2531/
</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Poked the playback API manually.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/include/asterisk/app.h <span style="color: grey">(388896)</span></li>

 <li>/trunk/include/asterisk/stasis_app_playback.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/trunk/include/asterisk/stasis_channels.h <span style="color: grey">(388896)</span></li>

 <li>/trunk/include/asterisk/stasis_http.h <span style="color: grey">(388896)</span></li>

 <li>/trunk/main/channel.c <span style="color: grey">(388896)</span></li>

 <li>/trunk/main/channel_internal_api.c <span style="color: grey">(388896)</span></li>

 <li>/trunk/main/stasis_channels.c <span style="color: grey">(388896)</span></li>

 <li>/trunk/res/res_stasis_http.c <span style="color: grey">(388896)</span></li>

 <li>/trunk/res/res_stasis_http_channels.c <span style="color: grey">(388896)</span></li>

 <li>/trunk/res/res_stasis_json_events.c <span style="color: grey">(388896)</span></li>

 <li>/trunk/res/res_stasis_json_events.exports.in <span style="color: grey">(388896)</span></li>

 <li>/trunk/res/res_stasis_playback.c <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/trunk/res/res_stasis_playback.exports.in <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/trunk/res/stasis/control.c <span style="color: grey">(388896)</span></li>

 <li>/trunk/res/stasis_http/resource_channels.h <span style="color: grey">(388896)</span></li>

 <li>/trunk/res/stasis_http/resource_channels.c <span style="color: grey">(388896)</span></li>

 <li>/trunk/res/stasis_http/resource_playback.c <span style="color: grey">(388896)</span></li>

 <li>/trunk/res/stasis_json/resource_channels.h <span style="color: grey">(388896)</span></li>

 <li>/trunk/res/stasis_json/resource_events.h <span style="color: grey">(388896)</span></li>

 <li>/trunk/rest-api/api-docs/channels.json <span style="color: grey">(388896)</span></li>

 <li>/trunk/rest-api/api-docs/events.json <span style="color: grey">(388896)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/2531/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>








  </div>
 </body>
</html>