<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2559/">https://reviewboard.asterisk.org/r/2559/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By David Lee.</div>
<p style="color: grey;"><i>Updated May 23, 2013, 3:21 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Committed in revision 389603</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-21587">ASTERISK-21587</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adds support for controlling a playback operation from the
Asterisk REST interface.
This adds the /playback/{playbackId}/control resource, which may be
POSTed to to pause, unpause, reverse, forward or restart the media
playback.
Attempts to control a playback that is not currently playing will
either return a 404 Not Found (because the playback object no longer
exists) or a 409 Conflict (because the playback object is still in the
queue to be played).
This patch also adds skipms and offsetms parameters to the
/channels/{channelId}/play resource.
(closes issue ASTERISK-21587)
Review: https://reviewboard.asterisk.org/r/2559</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Used swagger-ui to poke the playback control resource.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/team/dlee/playback-rebase/include/asterisk/app.h <span style="color: grey">(389484)</span></li>
<li>/team/dlee/playback-rebase/include/asterisk/channel.h <span style="color: grey">(389484)</span></li>
<li>/team/dlee/playback-rebase/include/asterisk/stasis_app.h <span style="color: grey">(389484)</span></li>
<li>/team/dlee/playback-rebase/include/asterisk/stasis_app_playback.h <span style="color: grey">(389484)</span></li>
<li>/team/dlee/playback-rebase/main/app.c <span style="color: grey">(389484)</span></li>
<li>/team/dlee/playback-rebase/res/res_stasis_http_channels.c <span style="color: grey">(389484)</span></li>
<li>/team/dlee/playback-rebase/res/res_stasis_playback.c <span style="color: grey">(389484)</span></li>
<li>/team/dlee/playback-rebase/res/stasis/control.c <span style="color: grey">(389484)</span></li>
<li>/team/dlee/playback-rebase/res/stasis_http/resource_channels.h <span style="color: grey">(389484)</span></li>
<li>/team/dlee/playback-rebase/res/stasis_http/resource_channels.c <span style="color: grey">(389484)</span></li>
<li>/team/dlee/playback-rebase/res/stasis_http/resource_playback.c <span style="color: grey">(389484)</span></li>
<li>/team/dlee/playback-rebase/rest-api/api-docs/channels.json <span style="color: grey">(389484)</span></li>
<li>/team/dlee/playback-rebase/rest-api/api-docs/playback.json <span style="color: grey">(389484)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2559/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>