<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2551/">https://reviewboard.asterisk.org/r/2551/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By rmudgett.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-21271">ASTERISK-21271</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is a fairly stand alone change on the way to making ConfBridge a subclass of ast_bridge.
* Made the ConfBridge recorder channel driver type name and channel name consistent. Before the channel driver type was ConfBridgeRec and the created channel name was ConfBridgeRecorder/conf-%s-uid-%d. Now it is CBRec and CBRec/conf-%s-uid-%d respectively.
* Replaced ConfBridge usage of chan_bridge with its own announcer channel.
* Deleted chan_bridge since it was created just for ConfBridge and it no longer uses it.
* The CBRec and CBAnn drivers set the recorder and announcer bridge channel roles respectively and are marked as IMMOVABLE to bridge merges and channel moves.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ConfBridge still is able to announce participants and play messages to the bridge.
ConfBridge still is able to record the conference.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/team/group/bridge_construction/apps/app_confbridge.c <span style="color: grey">(389037)</span></li>
<li>/team/group/bridge_construction/channels/chan_bridge.c <span style="color: grey">(389037)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2551/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>