<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2531/">https://reviewboard.asterisk.org/r/2531/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 14th, 2013, 11:31 a.m. CDT, <b>Joshua Colp</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/2531/diff/1/?file=37625#file37625line224" style="color: black; font-weight: bold; text-decoration: underline;">/team/dlee/res-stasis-cleanup/res/res_stasis_playback.c</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">224</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="n">playback_set_state</span><span class="p">(</span><span class="n">playback</span><span class="p">,</span> <span class="n">STASIS_PLAYBACK_STATE_QUEUED</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The queueing is nice but do you foresee a developer wanting to explicit play a sound file *now* without putting it in the queue behind others?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes.
They could achieve it with the given API by individually canceling all the queued playbacks, then playing what they really wanted to do. Very doable, but a bit of work on their end.
If our event that indicates that the playback has stopped includes the stopped point in the media, and if we added an '?offsetms=' parameter, then they could even resume playing the original media where it was interrupted.
Another alternative would be to add a parameter to the operation, in which we'll pretty much do the same thing for them. Feels like an add-that-later-when-we-need-it sort of thing, though.
</pre>
<br />
<p>- David</p>
<br />
<p>On May 10th, 2013, 1:52 p.m. CDT, David Lee wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By David Lee.</div>
<p style="color: grey;"><i>Updated May 10, 2013, 1:52 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-21283">ASTERISK-21283</a>,
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-21586">ASTERISK-21586</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">(depends on https://reviewboard.asterisk.org/r/2530)
This patch implements the REST API's for POST /channels/{channelId}/play
and GET /playback/{playbackId}.
This allows an external application to initiate playback of a sound on a
channel while the channel is in the Stasis application.
/play commands are issued asynchronously, and return immediately with
the URL of the associated /playback resource. Playback commands queue up,
playing in succession. The /playback resource shows the state of a
playback operation as enqueued, playing or complete. (Although the
operation will only be in the 'complete' state for a very short time,
since it is almost immediately freed up).
(closes issue ASTERISK-21283)
(closes issue ASTERISK-21586)
Review: https://reviewboard.asterisk.org/r/2531/
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Poked the playback API manually.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/team/dlee/res-stasis-cleanup/include/asterisk/stasis_app_playback.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/team/dlee/res-stasis-cleanup/include/asterisk/stasis_channels.h <span style="color: grey">(388370)</span></li>
<li>/team/dlee/res-stasis-cleanup/include/asterisk/stasis_http.h <span style="color: grey">(388370)</span></li>
<li>/team/dlee/res-stasis-cleanup/main/channel.c <span style="color: grey">(388370)</span></li>
<li>/team/dlee/res-stasis-cleanup/main/channel_internal_api.c <span style="color: grey">(388370)</span></li>
<li>/team/dlee/res-stasis-cleanup/main/stasis_channels.c <span style="color: grey">(388370)</span></li>
<li>/team/dlee/res-stasis-cleanup/res/res_stasis_http.c <span style="color: grey">(388370)</span></li>
<li>/team/dlee/res-stasis-cleanup/res/res_stasis_http_channels.c <span style="color: grey">(388370)</span></li>
<li>/team/dlee/res-stasis-cleanup/res/res_stasis_http_events.c <span style="color: grey">(388370)</span></li>
<li>/team/dlee/res-stasis-cleanup/res/res_stasis_playback.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/team/dlee/res-stasis-cleanup/res/res_stasis_playback.exports.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>/team/dlee/res-stasis-cleanup/res/stasis_http/resource_channels.h <span style="color: grey">(388370)</span></li>
<li>/team/dlee/res-stasis-cleanup/res/stasis_http/resource_channels.c <span style="color: grey">(388370)</span></li>
<li>/team/dlee/res-stasis-cleanup/res/stasis_http/resource_events.h <span style="color: grey">(388370)</span></li>
<li>/team/dlee/res-stasis-cleanup/res/stasis_http/resource_playback.c <span style="color: grey">(388370)</span></li>
<li>/team/dlee/res-stasis-cleanup/rest-api/api-docs/channels.json <span style="color: grey">(388370)</span></li>
<li>/team/dlee/res-stasis-cleanup/rest-api/api-docs/events.json <span style="color: grey">(388370)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2531/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>