<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2534/">https://reviewboard.asterisk.org/r/2534/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers and David Lee.</div>
<div>By opticron.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This moves the JSON event generators out of the Stasis-HTTP modules and into standalone JSON-related counterparts so that Stasis-HTTP and res_stasis can depend on them without creating dependency cycles. This also provides a future location for Swagger Model validator functions once the generators for that code are written.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ran app_replaced test from test_res_stasis which was the test that was causing a segfault on failed symbol lookup.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/res/stasis_json/resource_asterisk.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/res/stasis_http/resource_sounds.h <span style="color: grey">(388522)</span></li>
<li>trunk/res/stasis_http/resource_recordings.h <span style="color: grey">(388522)</span></li>
<li>trunk/res/stasis_http/resource_playback.h <span style="color: grey">(388522)</span></li>
<li>trunk/res/stasis_http/resource_events.h <span style="color: grey">(388522)</span></li>
<li>trunk/res/stasis_http/resource_endpoints.h <span style="color: grey">(388522)</span></li>
<li>trunk/res/stasis_http/resource_channels.h <span style="color: grey">(388522)</span></li>
<li>trunk/res/stasis_http/resource_bridges.h <span style="color: grey">(388522)</span></li>
<li>trunk/res/stasis_http/resource_asterisk.h <span style="color: grey">(388522)</span></li>
<li>trunk/res/res_stasis_json_sounds.exports.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/res/res_stasis_json_sounds.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/res/res_stasis_json_recordings.exports.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/res/res_stasis_json_recordings.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/res/res_stasis_json_playback.exports.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/res/res_stasis_json_playback.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/res/res_stasis_json_events.exports.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/res/res_stasis_json_events.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/res/res_stasis_json_endpoints.exports.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/res/res_stasis_json_endpoints.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/res/res_stasis_json_channels.exports.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/res/res_stasis_json_channels.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/res/res_stasis_json_bridges.exports.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/res/res_stasis_json_bridges.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/res/res_stasis_json_asterisk.exports.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/res/res_stasis_json_asterisk.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/res/res_stasis_http_events.c <span style="color: grey">(388522)</span></li>
<li>trunk/res/res_stasis.c <span style="color: grey">(388522)</span></li>
<li>trunk/res/stasis_json/resource_bridges.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/res/stasis_json/resource_channels.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/res/stasis_json/resource_endpoints.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/res/stasis_json/resource_events.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/res/stasis_json/resource_playback.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/res/stasis_json/resource_recordings.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/res/stasis_json/resource_sounds.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/rest-api-templates/make_stasis_http_stubs.py <span style="color: grey">(388522)</span></li>
<li>trunk/rest-api-templates/res_stasis_http_resource.c.mustache <span style="color: grey">(388522)</span></li>
<li>trunk/rest-api-templates/res_stasis_json_resource.c.mustache <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/rest-api-templates/res_stasis_json_resource.exports.mustache <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/rest-api-templates/stasis_http_resource.h.mustache <span style="color: grey">(388522)</span></li>
<li>trunk/rest-api-templates/stasis_json_resource.h.mustache <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/tests/test_res_stasis.c <span style="color: grey">(388522)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2534/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>