<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2465/">https://reviewboard.asterisk.org/r/2465/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think your latest diff is missing the actual native bridging mixing technology.</pre>
<br />
<p>- Matt</p>
<br />
<p>On April 29th, 2013, 2:19 p.m. UTC, Joshua Colp wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Joshua Colp.</div>
<p style="color: grey;"><i>Updated April 29, 2013, 2:19 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This change implements the following:
1. Adds a native RTP bridge technology which does local or remote bridging depending on conditions
2. Makes the bridging core aware of native bridges
3. Calls into the compatible callback of bridging technologies when present to check compatibility
4. Tweaks some logic to cause the bridge to reconfigure when external conditions influence it</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">1. Tested that non-RTP channels do not cause the native RTP bridge to be used
2. Tested that if conditions allow it that remote bridging (ala reinvite) occurs
3. Tested that if remote bridging is not possible that local bridging occurs
4. Tested that if conditions are not correct none of the above happens
5. Tested that external applications cause the bridge to be reconfigured, and alternate technology used if needed</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/team/group/bridge_construction/apps/app_chanspy.c <span style="color: grey">(386842)</span></li>
<li>/team/group/bridge_construction/apps/app_mixmonitor.c <span style="color: grey">(386842)</span></li>
<li>/team/group/bridge_construction/channels/chan_gulp.c <span style="color: grey">(386842)</span></li>
<li>/team/group/bridge_construction/channels/chan_h323.c <span style="color: grey">(386842)</span></li>
<li>/team/group/bridge_construction/channels/chan_jingle.c <span style="color: grey">(386842)</span></li>
<li>/team/group/bridge_construction/channels/chan_mgcp.c <span style="color: grey">(386842)</span></li>
<li>/team/group/bridge_construction/channels/chan_motif.c <span style="color: grey">(386842)</span></li>
<li>/team/group/bridge_construction/channels/chan_sip.c <span style="color: grey">(386842)</span></li>
<li>/team/group/bridge_construction/channels/chan_skinny.c <span style="color: grey">(386842)</span></li>
<li>/team/group/bridge_construction/channels/chan_unistim.c <span style="color: grey">(386842)</span></li>
<li>/team/group/bridge_construction/include/asterisk/rtp_engine.h <span style="color: grey">(386842)</span></li>
<li>/team/group/bridge_construction/main/bridging.c <span style="color: grey">(386842)</span></li>
<li>/team/group/bridge_construction/main/rtp_engine.c <span style="color: grey">(386842)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2465/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>