<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2464/">https://reviewboard.asterisk.org/r/2464/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/2464/diff/1/?file=36332#file36332line2" style="color: black; font-weight: bold; text-decoration: underline;">/asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/off-nominal/md5/configs/ast1/modules.conf</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">2</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">autoload = no</pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">We should be using the default modules.conf from make samples, what differences are there between this one and the sample?</pre>
</div>
<br />
<p>- Paul</p>
<br />
<p>On April 23rd, 2013, 2:30 p.m. UTC, jbigelow wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers and Mark Michelson.</div>
<div>By jbigelow.</div>
<p style="color: grey;"><i>Updated April 23, 2013, 2:30 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
testsuite
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This test sends various calls to res_sip for which authentication is expected to fail. This covers test #2 of the off-nominal paths listed on the test plan page of the wiki. It sends the wrong username, password, and *realm using IPv4/IPv6 and UDP/TCP.
A small change was made to sipp.py to allow injection files to reside and be found in the sipp sub directory of the test directory.
* The realm is simply changed and the response digest is not recalculated in the Authorization header due to SIPp limitations.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">* Ensured that all 24 combinations fail as expected.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/asterisk/team/group/pimp_my_sip/lib/python/asterisk/sipp.py <span style="color: grey">(3734)</span></li>
<li>/asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/off-nominal/md5/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/off-nominal/md5/configs/ast1/modules.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/off-nominal/md5/configs/ast1/res_sip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/off-nominal/md5/sipp/credentials-wrong_pass.csv <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/off-nominal/md5/sipp/credentials-wrong_realm.csv <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/off-nominal/md5/sipp/credentials-wrong_user.csv <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/off-nominal/md5/sipp/playback_with_initial_sdp.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/off-nominal/md5/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/off-nominal/tests.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/off-nominal/userpass/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/off-nominal/userpass/configs/ast1/modules.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/off-nominal/userpass/configs/ast1/res_sip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/off-nominal/userpass/sipp/credentials-wrong_pass.csv <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/off-nominal/userpass/sipp/credentials-wrong_realm.csv <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/off-nominal/userpass/sipp/credentials-wrong_user.csv <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/off-nominal/userpass/sipp/playback_with_initial_sdp.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/off-nominal/userpass/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/tests.yaml <span style="color: grey">(3734)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2464/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>