<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2490/">https://reviewboard.asterisk.org/r/2490/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers, David Lee, kmoore, and Matt Jordan.</div>
<div>By jrose.</div>
<p style="color: grey;"><i>Updated May 2, 2013, 3:55 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Address Matt's review.
AST_EVENT_DEVICE_STATE_CHANGE remains defined due to res_corosync.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-21103">ASTERISK-21103</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">A continuation of the effort started with https://reviewboard.asterisk.org/r/2481
This one replaces the NETWORK_CHANGE events. I added the system topic and it is stored in/is registed by asterisk.c at startup.
It's worth noting that NETWORK_CHANGE events had no data associated with them before. Since generating stasis messages ao2_refs the
data going in, some ao2_object has to be included, so I went ahead and gave it a blank JSON object wrapped in a json_payload similar
to how I handled the ACL change messages.
Part 2/3</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Since the only thing that generates these messages under normal conditions is res_stun_monitor and I don't really know how to or particularly want to set up a stun server, I simply used a test function that would generate the messages in the same way as they are when the STUN monitor would issue them. I made sure that each of the consumers (which are just chan_sip and chan_iax2) reacted to the messages as anticipated and they did.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/res/res_stun_monitor.c <span style="color: grey">(387038)</span></li>
<li>/trunk/main/event.c <span style="color: grey">(387038)</span></li>
<li>/trunk/main/asterisk.c <span style="color: grey">(387038)</span></li>
<li>/trunk/include/asterisk.h <span style="color: grey">(387038)</span></li>
<li>/trunk/include/asterisk/event_defs.h <span style="color: grey">(387038)</span></li>
<li>/trunk/channels/chan_sip.c <span style="color: grey">(387038)</span></li>
<li>/trunk/channels/chan_iax2.c <span style="color: grey">(387038)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2490/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>