<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/2464/">https://reviewboard.asterisk.org/r/2464/</a>
     </td>
    </tr>
   </table>
   <br />











<div>




<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="https://reviewboard.asterisk.org/r/2464/diff/1/?file=36331#file36331line3" style="color: black; font-weight: bold; text-decoration: underline;">/asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/off-nominal/md5/configs/ast1/extensions.conf</a>
    <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>



 
 

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
    <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">3</font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">same  =&gt;          n,Playback(hello-world)</pre></td>
  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I&#39;d recommend using Echo() here so the test isn&#39;t time-constrained in dialplan.</pre>
</div>
<br />

<div>




<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="https://reviewboard.asterisk.org/r/2464/diff/1/?file=36332#file36332line13" style="color: black; font-weight: bold; text-decoration: underline;">/asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/off-nominal/md5/configs/ast1/modules.conf</a>
    <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>



 
 

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
    <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">13</font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">load =&gt; app_playback.so</pre></td>
  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
    <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">14</font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">load =&gt; app_echo.so</pre></td>
  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
    <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">15</font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">load =&gt; format_gsm.so</pre></td>
  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
    <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">16</font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">load =&gt; codec_gsm.so</pre></td>
  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If you choose to use Echo, you can drop app_playback and format_gsm from this list (probably codec_gsm as well).</pre>
</div>
<br />

<div>




<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="https://reviewboard.asterisk.org/r/2464/diff/1/?file=36333#file36333line15" style="color: black; font-weight: bold; text-decoration: underline;">/asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/off-nominal/md5/configs/ast1/res_sip.conf</a>
    <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>



 
 

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
    <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">15</font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">[local-transport-tcp](local-transport-template)</pre></td>
  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
    <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">16</font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">protocol=tcp</pre></td>
  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
    <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">17</font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
    <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">18</font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">[local-transport-tcp](local-transport6-template)</pre></td>
  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
    <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">19</font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">protocol=tcp</pre></td>
  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You have a duplicate transport context name here even though the templates used vary.</pre>
</div>
<br />

<div>




<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="https://reviewboard.asterisk.org/r/2464/diff/1/?file=36337#file36337line95" style="color: black; font-weight: bold; text-decoration: underline;">/asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/off-nominal/md5/sipp/playback_with_initial_sdp.xml</a>
    <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>



 
 

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
    <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">95</font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">       <span class="nt">&lt;ereg</span> <span class="na">regexp=</span><span class="s">&quot;Authorization:.*realm=\&quot;</span><span class="err">&quot;</span> <span class="na">search_in=</span><span class="s">&quot;var&quot;</span> <span class="na">variable=</span><span class="s">&quot;origauthrsphdr&quot;</span> <span class="na">assign_to=</span><span class="s">&quot;beforerealm&quot;</span> <span class="nt">/&gt;</span></pre></td>
  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is invalid XML (flagged by reviewboard as well).</pre>
</div>
<br />

<div>




<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="https://reviewboard.asterisk.org/r/2464/diff/1/?file=36337#file36337line102" style="color: black; font-weight: bold; text-decoration: underline;">/asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/off-nominal/md5/sipp/playback_with_initial_sdp.xml</a>
    <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>



 
 

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
    <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">102</font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">       <span class="nt">&lt;ereg</span> <span class="na">regexp=</span><span class="s">&quot;\&quot;</span><span class="err">,</span><span class="na">cnonce=</span><span class="s">.*&quot;</span> <span class="na">search_in=</span><span class="s">&quot;var&quot;</span> <span class="na">variable=</span><span class="s">&quot;origauthrsphdr&quot;</span> <span class="na">assign_to=</span><span class="s">&quot;afterrealm&quot;</span> <span class="nt">/&gt;</span></pre></td>
  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Idem.</pre>
</div>
<br />



 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The comments above apply to the respective files in both tests.</pre>

<p>- opticron</p>


<br />
<p>On April 23rd, 2013, 9:30 a.m. CDT, jbigelow wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Asterisk Developers and Mark Michelson.</div>
<div>By jbigelow.</div>


<p style="color: grey;"><i>Updated April 23, 2013, 9:30 a.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
testsuite
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This test sends various calls to res_sip for which authentication is expected to fail. This covers test #2 of the off-nominal paths listed on the test plan page of the wiki. It sends the wrong username, password, and *realm using IPv4/IPv6 and UDP/TCP. 

A small change was made to sipp.py to allow injection files to reside and be found in the sipp sub directory of the test directory.

* The realm is simply changed and the response digest is not recalculated in the Authorization header due to SIPp limitations.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">* Ensured that all 24 combinations fail as expected.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/asterisk/team/group/pimp_my_sip/lib/python/asterisk/sipp.py <span style="color: grey">(3734)</span></li>

 <li>/asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/off-nominal/md5/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/off-nominal/md5/configs/ast1/modules.conf <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/off-nominal/md5/configs/ast1/res_sip.conf <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/off-nominal/md5/sipp/credentials-wrong_pass.csv <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/off-nominal/md5/sipp/credentials-wrong_realm.csv <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/off-nominal/md5/sipp/credentials-wrong_user.csv <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/off-nominal/md5/sipp/playback_with_initial_sdp.xml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/off-nominal/md5/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/off-nominal/tests.yaml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/off-nominal/userpass/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/off-nominal/userpass/configs/ast1/modules.conf <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/off-nominal/userpass/configs/ast1/res_sip.conf <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/off-nominal/userpass/sipp/credentials-wrong_pass.csv <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/off-nominal/userpass/sipp/credentials-wrong_realm.csv <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/off-nominal/userpass/sipp/credentials-wrong_user.csv <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/off-nominal/userpass/sipp/playback_with_initial_sdp.xml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/off-nominal/userpass/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/team/group/pimp_my_sip/tests/channels/gulp/basic_calls/incoming/tests.yaml <span style="color: grey">(3734)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/2464/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>








  </div>
 </body>
</html>