<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2489/">https://reviewboard.asterisk.org/r/2489/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers and Matt Jordan.</div>
<div>By David Lee.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've noticed when doing a graceful shutdown that the res_stasis_http.so
module gets unloaded before the modules that use it, which causes some
asserts during their unload.
While r386928 was a quick hack to get it to not assert and die, this
patch increases the use counts on res_stasis.so and res_stasis_http.so
properly. It's a bigger change than I expected, hence the review instead
of just committing it.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Checked unload order when running core stop gracefully.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/apps/app_stasis.c <span style="color: grey">(386989)</span></li>
<li>/trunk/include/asterisk/stasis_app.h <span style="color: grey">(386989)</span></li>
<li>/trunk/main/loader.c <span style="color: grey">(386989)</span></li>
<li>/trunk/res/res_stasis.c <span style="color: grey">(386989)</span></li>
<li>/trunk/res/res_stasis_http.c <span style="color: grey">(386989)</span></li>
<li>/trunk/res/res_stasis_http_asterisk.c <span style="color: grey">(386989)</span></li>
<li>/trunk/res/res_stasis_http_bridges.c <span style="color: grey">(386989)</span></li>
<li>/trunk/res/res_stasis_http_channels.c <span style="color: grey">(386989)</span></li>
<li>/trunk/res/res_stasis_http_endpoints.c <span style="color: grey">(386989)</span></li>
<li>/trunk/res/res_stasis_http_events.c <span style="color: grey">(386989)</span></li>
<li>/trunk/res/res_stasis_http_playback.c <span style="color: grey">(386989)</span></li>
<li>/trunk/res/res_stasis_http_recordings.c <span style="color: grey">(386989)</span></li>
<li>/trunk/res/res_stasis_http_sounds.c <span style="color: grey">(386989)</span></li>
<li>/trunk/res/res_stasis_websocket.c <span style="color: grey">(386989)</span></li>
<li>/trunk/rest-api-templates/res_stasis_http_resource.c.mustache <span style="color: grey">(386989)</span></li>
<li>/trunk/tests/test_res_stasis.c <span style="color: grey">(386989)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2489/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>