<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/2468/">https://reviewboard.asterisk.org/r/2468/</a>
     </td>
    </tr>
   </table>
   <br />



 <p>Ship it!</p>



 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
 <br />









<p>- Joshua</p>


<br />
<p>On April 25th, 2013, 7:36 p.m. UTC, opticron wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Asterisk Developers.</div>
<div>By opticron.</div>


<p style="color: grey;"><i>Updated April 25, 2013, 7:36 p.m.</i></p>







<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="https://issues.asterisk.org/jira/browse/ASTERISK-21416">ASTERISK-21416</a>


</div>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add support for SDES SRTP in chan_gulp/res_sip.  Available options for media encryption for a given endpoint are deny (no encryption allowed), no (none offered by default, but silent upgrade to SDES allowed), and sdes.  This also supports mid-call rekeying as far as I could test it.  Much of the code necessary for this functionality was factored out of chan_sip or pulled from channels/sip/.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hand testing with several SRTP-capable endpoints and mid-call rekeying tested with minor tweaks to an otherwise unmodified chan_sip.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>team/group/pimp_my_sip/channels/chan_sip.c <span style="color: grey">(386429)</span></li>

 <li>team/group/pimp_my_sip/channels/sip/include/sdp_crypto.h <span style="color: grey">(386429)</span></li>

 <li>team/group/pimp_my_sip/channels/sip/include/sip.h <span style="color: grey">(386429)</span></li>

 <li>team/group/pimp_my_sip/channels/sip/include/srtp.h <span style="color: grey">(386429)</span></li>

 <li>team/group/pimp_my_sip/channels/sip/sdp_crypto.c <span style="color: grey">(386429)</span></li>

 <li>team/group/pimp_my_sip/channels/sip/srtp.c <span style="color: grey">(386429)</span></li>

 <li>team/group/pimp_my_sip/configs/res_sip.conf.sample <span style="color: grey">(386430)</span></li>

 <li>team/group/pimp_my_sip/include/asterisk/res_sip.h <span style="color: grey">(386429)</span></li>

 <li>team/group/pimp_my_sip/include/asterisk/res_sip_session.h <span style="color: grey">(386429)</span></li>

 <li>team/group/pimp_my_sip/include/asterisk/sdp_srtp.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>team/group/pimp_my_sip/main/sdp_srtp.c <span style="color: grey">(PRE-CREATION)</span></li>

 <li>team/group/pimp_my_sip/res/res_sip/sip_configuration.c <span style="color: grey">(386429)</span></li>

 <li>team/group/pimp_my_sip/res/res_sip_sdp_rtp.c <span style="color: grey">(386429)</span></li>

 <li>team/group/pimp_my_sip/res/res_sip_session.c <span style="color: grey">(386429)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/2468/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>








  </div>
 </body>
</html>