<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2481/">https://reviewboard.asterisk.org/r/2481/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers, David Lee, kmoore, and Matt Jordan.</div>
<div>By jrose.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-21103">ASTERISK-21103</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This only covers one element of ASTERISK-21103 (of 3) and I started with this one because it's the one I'm most personally familiar with.
The objective here was to remove the events issued by the named ACL system and replace them with stasis messages. Since ast_json structs
aren't refcounted, I created a payload to contain them to act as the stasis message data component. Since the use of these events was very
simple (the existing subscribers don't actually care about the data relayed by the events), it's an ideal starting point.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Made sure the stasis messages were being relayed and that my subscribers reacted to them. chan_iax2, chan_sip, and manager all reloaded as expected when I performed 'module reload acl'.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/channels/chan_iax2.c <span style="color: grey">(386859)</span></li>
<li>/trunk/channels/chan_sip.c <span style="color: grey">(386859)</span></li>
<li>/trunk/include/asterisk/acl.h <span style="color: grey">(386859)</span></li>
<li>/trunk/include/asterisk/event_defs.h <span style="color: grey">(386859)</span></li>
<li>/trunk/include/asterisk/json.h <span style="color: grey">(386859)</span></li>
<li>/trunk/main/json.c <span style="color: grey">(386859)</span></li>
<li>/trunk/main/manager.c <span style="color: grey">(386859)</span></li>
<li>/trunk/main/named_acl.c <span style="color: grey">(386859)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2481/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>