<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2476/">https://reviewboard.asterisk.org/r/2476/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers and Mark Michelson.</div>
<div>By Matt Jordan.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-21394">ASTERISK-21394</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, CDRs, yes, it's in a release branch.
Unfortunately, we accidentally changed the behavior of CDRs in 1.8 (specifically 1.8.9.0) in ASTERISK-19173, and this patch restores the previous behavior. So we're still within the ballpark of 'don't touch CDRs in a release branch' - we're trying *not* to touch them here.
ASTERISK-19173 looked to prevent the 'h' extension from being executed on channels in a blind transfer by setting the AST_FLAG_BRIDGE_HANGUP_DONT flag. It did this when it first detected the hangup frame. Unfortunately, setting this flag that early has other side effects - namely, it blows out the bridge_cdr information, removing the billing record information for the channel while it was in the bridge. Whoops.
Since we still have to avoid executing the 'h' extension, we look at the soft hangup flags before execution of said extension and skip it if the flags are set. This should preserve the behavior this patch intended to fix, while restoring the pre-1.8.9.0 behavior of CDRs.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested by Steve Davies (who wrote the patch) and Ishfaq Malik, who reported the issue. TestSuite also ran and passed.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/1.8/main/features.c <span style="color: grey">(386724)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2476/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>