<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2426/">https://reviewboard.asterisk.org/r/2426/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Alec Davis.</div>
<p style="color: grey;"><i>Updated April 19, 2013, 2:45 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-18827">ASTERISK-18827</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">On a slower machine when a full_frame with the same callno is already being processed by another thread the frame is queued onto the other thread.
However, nothing indicates to the other thread that it now has a frame to process.
On the bug report, I have debug messages in the patch.
In theory, the thread that is already processing the callno should pickup the deferred frames, but it doesn't.
What was also revealed in ASTERISK-18827 using iax_18827.diff2.txt, is that the deferred frames queue increases each time a POKE/PONG is initiated.
At some stage this will exhaust memory.
Refer to the line below
+ ast_log(LOG_WARNING, "ALEC[%d] unhandled frame on thread [%d]\n", from_here->threadnum, to_here->threadnum);
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Before patch:
astrid-test*CLI> iax2 show threads
IAX2 Thread Information
Idle Threads:
Thread 2: state=0, update=5, actions=4, func=''
Thread 3: state=0, update=4, actions=2, func=''
Thread 4: state=0, update=10, actions=2, func=''
Thread 5: state=0, update=3, actions=4, func=''
Thread 6: state=0, update=8, actions=2, func=''
Thread 7: state=0, update=2, actions=3, func=''
Thread 8: state=0, update=1, actions=3, func=''
Thread 9: state=0, update=0, actions=3, func=''
Thread 10: state=0, update=6, actions=1, func=''
Active Threads:
Thread P1: state=1, update=1365045454, actions=0, func='socket_process'
Dynamic Threads:
10 of 10 threads accounted for with 0 dynamic threads
and iax2 show peers reports link is UNREACHABLE
After patch:
iax2 show threads has all idle.
iax2 show peers (immediately after 'module load chan_iax2.so')
Name/Username Host Mask Port Status Description
astrid2/astrid2 192.168.xxx.yyy (S) 255.255.255.255 4569 (T) OK (1002 ms)
1 iax2 peers [1 online, 0 offline, 0 unmonitored]
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/channels/chan_iax2.c <span style="color: grey">(376441)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2426/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>