<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2446/">https://reviewboard.asterisk.org/r/2446/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've looked through this on a couple of occasions now and I think it's good to go.</pre>
<br />
<p>- jrose</p>
<br />
<p>On April 12th, 2013, 6:10 p.m. UTC, rmudgett wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By rmudgett.</div>
<p style="color: grey;"><i>Updated April 12, 2013, 6:10 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-21332">ASTERISK-21332</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Create the basic bridge subclass of struct ast_bridge. This bridge class is the normal bridge for most calls. It adds management of the DTMF feature hooks for each channel while they are in this bridge. When the basic two party bridge expands into a multi-party bridge, the various parties can drop out of the bridge without destroying it.
The new bridging API does not allow casual knowledge of what channels are bridged with a particular channel because there can be more than one. With this restriction, the support of the [applicationmap] ActivatedBy feature option no longer makes sense and cannot be supported. The ActivatedBy option is now just ignored. The feature can only be activated by the channel it is attached to and not by its peer.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Normal calls are able to do DTMF blind and attended transfers. The features.conf [featuremap], [applicationmap], and feature-group sections work as expected. The DYNAMIC_FEATURES channel variable is parsed just like before with the exception of the ActivatedBy option.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>team/group/bridge_construction/funcs/func_channel.c <span style="color: grey">(385512)</span></li>
<li>team/group/bridge_construction/include/asterisk/bridging_basic.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>team/group/bridge_construction/include/asterisk/bridging_features.h <span style="color: grey">(385512)</span></li>
<li>team/group/bridge_construction/main/bridging.c <span style="color: grey">(385512)</span></li>
<li>team/group/bridge_construction/main/bridging_basic.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>team/group/bridge_construction/main/features.c <span style="color: grey">(385512)</span></li>
<li>team/group/bridge_construction/configs/features.conf.sample <span style="color: grey">(385512)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2446/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>