<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2422/">https://reviewboard.asterisk.org/r/2422/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/2422/diff/1/?file=35321#file35321line27" style="color: black; font-weight: bold; text-decoration: underline;">/branches/1.8/contrib/realtime/mysql/sippeers.sql</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">27</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="o">`</span><span class="n">nat</span><span class="o">`</span> <span class="n">enum</span><span class="p">(</span><span class="s1">'yes'</span><span class="p">,</span><span class="s1">'no'</span><span class="p">,</span><span class="s1">'<span class="hl">never</span>'</span><span class="p">,</span><span class="s1">'<span class="hl">route</span>'</span><span class="p">)</span> <span class="k">DEFAULT</span> <span class="k">NULL</span><span class="p">,</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">27</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="o">`</span><span class="n">nat</span><span class="o">`</span> <span class="n">enum</span><span class="p">(</span><span class="s1">'yes'</span><span class="p">,</span><span class="s1">'no'</span><span class="p">,</span><span class="s1">'<span class="hl">force_rport</span>'</span><span class="p">,</span><span class="s1">'<span class="hl">comedia</span>'</span><span class="p">)</span> <span class="k">DEFAULT</span> <span class="k">NULL</span><span class="p">,</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is not an enum since at least 11.
Better not restrict it in the past so people get an easier upgrade path when moving from 1.8 to newer. I suggest a large enough varchar to at least fit the two new auto_* options.
<quote from 11>
; The nat settings can be combined. For example, to set both force_rport and comedia
; one would set nat=force_rport,comedia. If any of the comma-separated options is 'no',
</quote></pre>
</div>
<br />
<p>- wdoekes</p>
<br />
<p>On April 2nd, 2013, 8:14 p.m. UTC, Michael Young wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Michael Young.</div>
<p style="color: grey;"><i>Updated April 2, 2013, 8:14 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-21243">ASTERISK-21243</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ASTERISK-20904 was centered around the changes that took place in Asterisk 11 in regards to the auto_* NAT settings. Since the report stated that 1.8 was fine but that 11 had an issue, the focus was on Asterisk 11.
While working on ASTERISK-21225, I saw that 1.8 would benefit from some of those changes but requires a different patch.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">compile test
Same changes as ASTERISK-20904 but for 1.8 - so, we can kind of say it has been tested :)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/1.8/channels/chan_sip.c <span style="color: grey">(382826)</span></li>
<li>/branches/1.8/contrib/realtime/mysql/sippeers.sql <span style="color: grey">(382826)</span></li>
<li>/branches/1.8/contrib/realtime/postgresql/realtime.sql <span style="color: grey">(382826)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2422/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>