<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2371/">https://reviewboard.asterisk.org/r/2371/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/2371/diff/3/?file=35012#file35012line206" style="color: black; font-weight: bold; text-decoration: underline;">/asterisk/trunk/lib/python/asterisk/TestCase.py</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">def create_ami_factory(self, count=1, username="user", secret="mysecret", port=5038):</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">206</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">logger</span><span class="o">.</span><span class="n">info</span><span class="p">(</span><span class="s">"Tzafrir: username: </span><span class="si">%s</span><span class="s">, secret: </span><span class="si">%s</span><span class="s">"</span> <span class="o">%</span> <span class="p">(</span><span class="n">username</span><span class="p">,</span> <span class="n">secret</span><span class="p">))</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This can go away.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/2371/diff/3/?file=35013#file35013line716" style="color: black; font-weight: bold; text-decoration: underline;">/asterisk/trunk/lib/python/asterisk/asterisk.py</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">def __mirror_dir(self, ast_dir_name, ast_dir_path, cache):</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">716</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">real_dirname</span> <span class="o">=</span> <span class="n">re</span><span class="o">.</span><span class="n">sub</span><span class="p">(</span><span class="n">Asterisk</span><span class="o">.</span><span class="n">local_root</span><span class="p">,</span> <span class="s">''</span><span class="p">,</span> <span class="n">dirname</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This simple string replacement can be done with string.replace(). No need to dive into regex land.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/2371/diff/3/?file=35013#file35013line734" style="color: black; font-weight: bold; text-decoration: underline;">/asterisk/trunk/lib/python/asterisk/asterisk.py</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">def __mirror_dir(self, ast_dir_name, ast_dir_path, cache):</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">722</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="bp">self</span><span class="o">.</span><span class="n">__makedirs</span><span class="p">(</span><span class="n">os</span><span class="o">.</span><span class="n">path</span><span class="o">.</span><span class="n">join</span><span class="p">(</span><span class="n">target_dir</span><span class="p">,</span> <span class="n">dirname</span><span class="p">,</span> <span class="n">d</span><span class="p">))</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">734</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">real_dirname</span> <span class="o">=</span> <span class="n">re</span><span class="o">.</span><span class="n">sub</span><span class="p">(</span><span class="n">Asterisk</span><span class="o">.</span><span class="n">local_root</span><span class="p">,</span> <span class="s">''</span><span class="p">,</span> <span class="n">dirname</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Idem.</pre>
</div>
<br />
<p>- opticron</p>
<br />
<p>On March 23rd, 2013, 4:23 a.m. CDT, Tzafrir Cohen wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Tzafrir Cohen.</div>
<p style="color: grey;"><i>Updated March 23, 2013, 4:23 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
testsuite
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Place anything needed for the test suite (except the actual sources of Asterisk) under the test suite directory.
Fix parts in the python code. Add a wrapper script (run_local) for the required automation.
Work is still needed on asttest (add a destdir option? Consolidate all the run-test scripts to run it through a common function?) but I'm not exactly sure how the information is passed to Lua.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/asterisk/trunk/tests/channels/SIP/sip_channel_params/run-test <span style="color: grey">(3678)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/tcpauthlimit/run-test <span style="color: grey">(3678)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/tcpauthtimeout/run-test <span style="color: grey">(3678)</span></li>
<li>/asterisk/trunk/tests/fax/local_channel_t38_queryoption/run-test <span style="color: grey">(3678)</span></li>
<li>/asterisk/trunk/tests/cdr/blind-transfer-accountcode/run-test <span style="color: grey">(3678)</span></li>
<li>/asterisk/trunk/tests/cdr/originate-cdr-disposition/run-test <span style="color: grey">(3678)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/handle_response_refer/run-test <span style="color: grey">(3678)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/rfc2833_dtmf_detect/run-test <span style="color: grey">(3678)</span></li>
<li>/asterisk/trunk/run-local <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/queues/macro_gosub_test/run-test <span style="color: grey">(3678)</span></li>
<li>/asterisk/trunk/tests/apps/queues/position_priority_maxlen/run-test <span style="color: grey">(3678)</span></li>
<li>/asterisk/trunk/tests/apps/queues/ringinuse_and_pause/run-test <span style="color: grey">(3678)</span></li>
<li>/asterisk/trunk/tests/apps/queues/wrapup_time/run-test <span style="color: grey">(3678)</span></li>
<li>/asterisk/trunk/tests/cdr/app_dial_G_flag/run-test <span style="color: grey">(3678)</span></li>
<li>/asterisk/trunk/tests/cdr/app_queue/run-test <span style="color: grey">(3678)</span></li>
<li>/asterisk/trunk/README.txt <span style="color: grey">(3678)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/TestCase.py <span style="color: grey">(3678)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/asterisk.py <span style="color: grey">(3678)</span></li>
<li>/asterisk/trunk/tests/manager/action-events-response/run-test <span style="color: grey">(3678)</span></li>
<li>/asterisk/trunk/tests/manager/authlimit/run-test <span style="color: grey">(3678)</span></li>
<li>/asterisk/trunk/tests/manager/authtimeout/run-test <span style="color: grey">(3678)</span></li>
<li>/asterisk/trunk/tests/manager/response-time/run-test <span style="color: grey">(3678)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2371/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>