<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2397/">https://reviewboard.asterisk.org/r/2397/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By wdoekes.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">------------------------------------------------------------------------
r2361 | radix | 2002-08-11 02:37:02 +0200 (Sun, 11 Aug 2002) | 8 lines
Changes to Deferred and Failure to make deferred errbacks more consistent
* Failure can now accept arbitrary objects as the `value', but
* passing a string is depracated and will trigger a warning.
* This changes the API slightly, as non-Failure objects passed to
Deferred.errback will be embedded in a Failure before being passed to
the errback chain.
* Update tests to follow new API.
------------------------------------------------------------------------
Before:
[Mar 18 11:45:50] ERROR[2119]: asterisk:257 __wait_fully_booted_error: Asterisk core waitfullybooted for 127.0.0.1 failed
/usr/lib/python2.6/dist-packages/twisted/internet/defer.py:305: DeprecationWarning: Don't pass strings (like 'Command core waitfullybooted failed') to failure.Failure (replacing with a DefaultException).
fail = failure.Failure(fail)
[Mar 18 11:45:50] ERROR[2119]: TestCase:251 __check_success_failure: [Failure instance: Traceback (failure with no frames): <class 'twisted.python.failure.DefaultException'>: Command core waitfullybooted failed
]
After:
[Mar 18 12:16:30] ERROR[6011]: asterisk:257 __wait_fully_booted_error: Asterisk core waitfullybooted for 127.0.0.1 failed
[Mar 18 12:16:30] ERROR[6011]: TestCase:251 __check_success_failure: Command core waitfullybooted failed
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/asterisk/trunk/lib/python/asterisk/TestCase.py <span style="color: grey">(3668)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/asterisk.py <span style="color: grey">(3668)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2397/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>