<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2384/">https://reviewboard.asterisk.org/r/2384/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I see a lot of duplicate extensions.conf and sip.conf files. Might I suggest either setting up symlink for the ast1 folders, or do what we do for the fastagi tests. This should help cut down the administrative tasks related to maintaining the testsuite.</pre>
<br />
<p>- Paul</p>
<br />
<p>On March 15th, 2013, 4:34 p.m., Matt Jordan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Matt Jordan.</div>
<p style="color: grey;"><i>Updated March 15, 2013, 4:34 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">For the CDR work being done for Asterisk 12, we need channel information as it pertains to Dialing to be pushed over the Stasis-Core message bus. As well, AMI (per the specification here https://wiki.asterisk.org/wiki/display/AST/AMI+1.4+Specification) requires knowledge of dialing to be able to raise the corresponding DialBegin/DialEnd events.
While the CDR work isn't ready yet for testing, AMI is much easier to port over to Stasis-Core - see Review https://reviewboard.asterisk.org/r/2383. These tests can be extended to verify any functionality that consumes the state of channels during a Dial operation - CDRs, CEL, etc.
This review provides a number of tests to cover Dial operations and the AMI events they produce. The following scenarios are covered:
-- Single Party --
* Dialing an endpoint and having it Answer
* Dialing an endpoint and having it reply back with a Busy
* Dialing an endpoint and having it be Unavailable
* Dialing an endpoint and having it reply back as Congested
* Dialing an endpoint and having the operation time out
* Dialing an endpoint and having the caller press a DTMF key that hangs them up, cancelling the dial operation
-- Multi Party --
* Dialing two endpoints, having one Answer and the verifying that the other one gets Cancelled
* Dialing two endpoints, having both be Busy/one Answer and the other be Busy
* Dialing two endpoints, having both be Congested/one Answer and the other be Congested
* Dialing two endpoints, having both be Unavailable/one Answer and the other be Unavailable
* Dialing two endpoints and having the caller press a DTMF key that hangs them up, cancelling both dial operations
</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-21196">ASTERISK-21196</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/asterisk/trunk/lib/python/asterisk/PluggableModules.py <span style="color: grey">(3666)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/ami.py <span style="color: grey">(3666)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_answer/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_answer/configs/ast1/sip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_answer/sipp/charlie.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_answer/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_busy/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_busy/configs/ast1/sip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_busy/sipp/bob.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_busy/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_congestion/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_congestion/configs/ast1/sip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_congestion/sipp/bob.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_congestion/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_dtmf_hangup_cancel/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_dtmf_hangup_cancel/configs/ast1/sip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_dtmf_hangup_cancel/send_dtmf.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_dtmf_hangup_cancel/sipp/bob.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_dtmf_hangup_cancel/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_no_answer/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_no_answer/configs/ast1/sip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_no_answer/sipp/bob.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_no_answer/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_parallel/dial_parallel_all_busy/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_parallel/dial_parallel_all_busy/configs/ast1/sip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_parallel/dial_parallel_all_busy/sipp/ua_busy.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_parallel/dial_parallel_all_busy/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_parallel/dial_parallel_all_cancel/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_parallel/dial_parallel_all_cancel/configs/ast1/sip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_parallel/dial_parallel_all_cancel/send_dtmf.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_parallel/dial_parallel_all_cancel/sipp/ua_wait_cancel.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_parallel/dial_parallel_all_cancel/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_parallel/dial_parallel_all_congestion/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_parallel/dial_parallel_all_congestion/configs/ast1/sip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_parallel/dial_parallel_all_congestion/sipp/ua_congestion.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_parallel/dial_parallel_all_congestion/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_parallel/dial_parallel_all_no_answer/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_parallel/dial_parallel_all_no_answer/configs/ast1/sip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_parallel/dial_parallel_all_no_answer/sipp/ua_no_answer.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_parallel/dial_parallel_all_no_answer/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_parallel/dial_parallel_all_unavail/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_parallel/dial_parallel_all_unavail/configs/ast1/sip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_parallel/dial_parallel_all_unavail/sipp/ua_unavail.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_parallel/dial_parallel_all_unavail/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_parallel/dial_parallel_answer_cancel/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_parallel/dial_parallel_answer_cancel/configs/ast1/sip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_parallel/dial_parallel_answer_cancel/sipp/bob.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_parallel/dial_parallel_answer_cancel/sipp/charlie.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_parallel/dial_parallel_answer_cancel/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_parallel/dial_parallel_single_busy/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_parallel/dial_parallel_single_busy/configs/ast1/sip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_parallel/dial_parallel_single_busy/sipp/bob.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_parallel/dial_parallel_single_busy/sipp/charlie.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_parallel/dial_parallel_single_busy/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_parallel/dial_parallel_single_congestion/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_parallel/dial_parallel_single_congestion/configs/ast1/sip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_parallel/dial_parallel_single_congestion/sipp/bob.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_parallel/dial_parallel_single_congestion/sipp/charlie.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_parallel/dial_parallel_single_congestion/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_parallel/dial_parallel_single_no_answer/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_parallel/dial_parallel_single_no_answer/configs/ast1/sip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_parallel/dial_parallel_single_no_answer/sipp/bob.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_parallel/dial_parallel_single_no_answer/sipp/charlie.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_parallel/dial_parallel_single_no_answer/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_parallel/dial_parallel_single_unavail/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_parallel/dial_parallel_single_unavail/configs/ast1/sip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_parallel/dial_parallel_single_unavail/sipp/bob.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_parallel/dial_parallel_single_unavail/sipp/charlie.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_parallel/dial_parallel_single_unavail/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_parallel/tests.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_timeout/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_timeout/configs/ast1/sip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_timeout/sipp/bob.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_timeout/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_unavail/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_unavail/configs/ast1/sip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_unavail/sipp/bob.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/dial_unavail/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/dial/tests.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/tests.yaml <span style="color: grey">(3666)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2384/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>