<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/2370/">https://reviewboard.asterisk.org/r/2370/</a>
     </td>
    </tr>
   </table>
   <br />



 <p>Ship it!</p>



 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Besides the warning message seems sane to me.</pre>
 <br />





<div>




<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="https://reviewboard.asterisk.org/r/2370/diff/1/?file=33878#file33878line28882" style="color: black; font-weight: bold; text-decoration: underline;">branches/1.8/channels/chan_sip.c</a>
    <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">static int reload_config(enum channelreloadreason reason)</pre></td>

  </tr>
 </tbody>



 
 




 <tbody>

  <tr>
    <th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">28882</font></th>
    <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">                <span class="k">if</span> <span class="p">(</span><span class="o">!</span><span class="n">ast_tls_read_conf</span><span class="p">(</span><span class="o">&amp;</span><span class="n">default_tls_cfg</span><span class="p">,</span> <span class="o">&amp;</span><span class="n">sip_tls_desc</span><span class="p">,</span> <span class="n">v</span><span class="o">-&gt;</span><span class="n">name</span><span class="p">,</span> <span class="n">v</span><span class="o">-&gt;</span><span class="n">value</span><span class="p">))</span> <span class="p">{</span></pre></td>
    <th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">28882</font></th>
    <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">                <span class="k">if</span> <span class="p">(</span><span class="n"><span class="hl">strcasecmp</span></span><span class="p"><span class="hl">(</span></span><span class="n"><span class="hl">v</span></span><span class="o"><span class="hl">-&gt;</span></span><span class="n"><span class="hl">name</span></span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="s"><span class="hl">&quot;tlsverifyclient&quot;</span></span><span class="p"><span class="hl">)</span></span><span class="hl"> </span><span class="o"><span class="hl">&amp;&amp;</span></span><span class="hl"> </span><span class="o">!</span><span class="n">ast_tls_read_conf</span><span class="p">(</span><span class="o">&amp;</span><span class="n">default_tls_cfg</span><span class="p">,</span> <span class="o">&amp;</span><span class="n">sip_tls_desc</span><span class="p">,</span> <span class="n">v</span><span class="o">-&gt;</span><span class="n">name</span><span class="p">,</span> <span class="n">v</span><span class="o">-&gt;</span><span class="n">value</span><span class="p">))</span> <span class="p">{</span></pre></td>
  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In the case of chan_sip I&#39;d like this to output a warning message so the user is aware that the option is not supported/isn&#39;t being obeyed.</pre>
</div>
<br />



<p>- Joshua</p>


<br />
<p>On March 6th, 2013, 12:14 p.m., opticron wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Asterisk Developers.</div>
<div>By opticron.</div>


<p style="color: grey;"><i>Updated March 6, 2013, 12:14 p.m.</i></p>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">AMI, HTTP, and chan_sip all support TLS in some way, but none of them support all the options that Asterisk&#39;s TLS core is capable of interpreting.  This prevents consumers of the TLS/SSL layer from setting TLS/SSL options that they do not support.

This also gets tlsverifyclient closer to a working state by requesting the client certificate when tlsverifyclient is set.  Currently, there is no consumer of main/tcptls.c in Asterisk that supports this feature and so it can not be properly tested.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ensured chan_sip would ignore tlsverifyclient.</pre>
  </td>
 </tr>
</table>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="https://issues.asterisk.org/jira/browse/AST-1093">AST-1093</a>


</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>branches/1.8/channels/chan_sip.c <span style="color: grey">(382511)</span></li>

 <li>branches/1.8/main/http.c <span style="color: grey">(382511)</span></li>

 <li>branches/1.8/main/manager.c <span style="color: grey">(382511)</span></li>

 <li>branches/1.8/main/tcptls.c <span style="color: grey">(382511)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/2370/diff/" style="margin-left: 3em;">View Diff</a></p>




  </td>
 </tr>
</table>








  </div>
 </body>
</html>