<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2380/">https://reviewboard.asterisk.org/r/2380/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers, Mark Michelson and Joshua Colp.</div>
<div>By opticron.</div>
<p style="color: grey;"><i>Updated March 11, 2013, 4:47 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Update to handle WebRTC-style RTP muxing in the SDP validation routine.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Abstract media type restrictions out of res_sip_session and move them to chan_gulp where they're actually needed. Due to the change, the sdp handler callback structure has been modified to accept a ast_sip_session_media struct and had a destroy function added and ast_sip_session_media_position has been removed from res_sip_session.h
This will need updates when Pimp SIP NAT goes in.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested with call scenarios from SDP_offer_answer integration test using a quickly hacked together video sdp handler which may or may not work properly but responds like it should (cp res/res_sip_sdp_audio.c res/res_sip_sdp_video.c;sed -i 's/AUDIO/VIDEO/;s/audio/video/' res/res_sip_sdp_video.c)</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-21184">ASTERISK-21184</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>team/group/pimp_my_sip/channels/chan_gulp.c <span style="color: grey">(382643)</span></li>
<li>team/group/pimp_my_sip/include/asterisk/res_sip_session.h <span style="color: grey">(382643)</span></li>
<li>team/group/pimp_my_sip/res/res_sip_sdp_audio.c <span style="color: grey">(382643)</span></li>
<li>team/group/pimp_my_sip/res/res_sip_session.c <span style="color: grey">(382643)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2380/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>