<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2368/">https://reviewboard.asterisk.org/r/2368/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Cursory review looks good. I may give it a more thorough review later.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/2368/diff/4/?file=33866#file33866line27697" style="color: black; font-weight: bold; text-decoration: underline;">team/dlee/stasis-core/channels/chan_sip.c</a>
<span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">static int handle_request_publish(struct sip_pvt *p, struct sip_request *req, struct ast_sockaddr *addr, const uint32_t seqno, const char *uri)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">27690</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="n">mailbox</span><span class="o">-></span><span class="n">event_sub</span><span class="p">)</span> <span class="p">{</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">27690</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="n">mailbox</span><span class="o">-></span><span class="n">event_sub</span><span class="p">)</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">FWIW, unsubscribe is NULL safe.</pre>
</div>
<br />
<p>- David</p>
<br />
<p>On March 6th, 2013, 11:48 a.m., opticron wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers and David Lee.</div>
<div>By opticron.</div>
<p style="color: grey;"><i>Updated March 6, 2013, 11:48 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This converts the usage of the existing event system in Asterisk for MWI to use Stasis as the pubsub backend.
Note: This patch requires the changes in https://reviewboard.asterisk.org/r/2367/ to compile.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">MWI distribution to SIP phones has been tested manually as has the pollmailboxes option for voicemail.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-21097">ASTERISK-21097</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>team/dlee/stasis-core/apps/app_minivm.c <span style="color: grey">(382509)</span></li>
<li>team/dlee/stasis-core/apps/app_voicemail.c <span style="color: grey">(382509)</span></li>
<li>team/dlee/stasis-core/channels/chan_dahdi.c <span style="color: grey">(382509)</span></li>
<li>team/dlee/stasis-core/channels/chan_iax2.c <span style="color: grey">(382509)</span></li>
<li>team/dlee/stasis-core/channels/chan_mgcp.c <span style="color: grey">(382509)</span></li>
<li>team/dlee/stasis-core/channels/chan_sip.c <span style="color: grey">(382509)</span></li>
<li>team/dlee/stasis-core/channels/chan_skinny.c <span style="color: grey">(382509)</span></li>
<li>team/dlee/stasis-core/channels/chan_unistim.c <span style="color: grey">(382509)</span></li>
<li>team/dlee/stasis-core/channels/sig_pri.h <span style="color: grey">(382509)</span></li>
<li>team/dlee/stasis-core/channels/sig_pri.c <span style="color: grey">(382509)</span></li>
<li>team/dlee/stasis-core/channels/sip/include/sip.h <span style="color: grey">(382509)</span></li>
<li>team/dlee/stasis-core/include/asterisk/app.h <span style="color: grey">(382509)</span></li>
<li>team/dlee/stasis-core/include/asterisk/xmpp.h <span style="color: grey">(382509)</span></li>
<li>team/dlee/stasis-core/main/app.c <span style="color: grey">(382509)</span></li>
<li>team/dlee/stasis-core/main/asterisk.c <span style="color: grey">(382509)</span></li>
<li>team/dlee/stasis-core/res/res_jabber.c <span style="color: grey">(382509)</span></li>
<li>team/dlee/stasis-core/res/res_xmpp.c <span style="color: grey">(382509)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2368/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>