<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/2341/">https://reviewboard.asterisk.org/r/2341/</a>
     </td>
    </tr>
   </table>
   <br />



 <p>Ship it!</p>



 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks like it should do the trick.</pre>
 <br />







<p>- Mark</p>


<br />
<p>On February 22nd, 2013, 1:15 a.m., wdoekes wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Asterisk Developers.</div>
<div>By wdoekes.</div>


<p style="color: grey;"><i>Updated Feb. 22, 2013, 1:15 a.m.</i></p>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">get_rpid() only allows the quoted-string style display-name.

Remote-Party-ID    = &quot;Remote-Party-ID&quot; HCOLON rpid *(COMMA rpid)
rpid               =  [display-name] LAQUOT addr-spec RAQUOT *(SEMI rpi-token)
display-name       =  *(token LWS)/ quoted-string

This patch allows *(token LWS) too. (And one without trailing LWS.)


I could&#39;ve used the reqresp_parser functions, but I didn&#39;t want to change around too much in the 1.8 branch.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes.

Both
  Remote-Party-ID: abc &lt;sip:123@def&gt;;... =&gt; &quot;abc&quot;
and
  Remote-Party-ID: &quot;abc&quot; &lt;sip:123@def&gt;;... =&gt; &quot;abc&quot;
work.

As do:
  Remote-Party-ID: abc &lt;sip:123@def&gt;;... =&gt; &quot;abc&quot;
  Remote-Party-ID: abc def &lt;sip:123@def&gt;;... =&gt; &quot;abc def&quot;
  Remote-Party-ID: abc def&lt;sip:123@def&gt;;... =&gt; &quot;abc def&quot;</pre>
  </td>
 </tr>
</table>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="https://issues.asterisk.org/jira/browse/ASTERISK-21141">ASTERISK-21141</a>


</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/branches/1.8/channels/chan_sip.c <span style="color: grey">(381817)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/2341/diff/" style="margin-left: 3em;">View Diff</a></p>




  </td>
 </tr>
</table>








  </div>
 </body>
</html>